Building (deleted) Waterfox 56.2.8: error: missing documentation for macro

[Graham Perrin]

On 17/03/2019 19:54, Charlie Li wrote:

 > On 17/03/2019 12:25, Jan Beich wrote:
 >
 >> …
 >>
 >> Looks like a regression from Rust 1.33 update.
 >>
 >> Either remove missing_docs from #![deny(...)] lines (or lines 
themselves)
 >> for each one that triggers error (no need to bother with unused ones) or
 >> add MOZ_OPTIONS+=--disable-stylo to Makefile.local.
 >>
 >> …
 >
 > I simply followed the tip given in Mozilla bug 1521249 (remove
 > `#![deny(missing_docs)]`), and have been running with it since we
 > updated our lang/rust to 1.33:
 > https://bugzilla.mozilla.org/show_bug.cgi?id=1521249#c36
 >
 > …

Thank you both.

In my fork: <https://github.com/grahamperrin/Waterfox/pull/7/files> – at 
a glance, does that look OK?

I'm unsure about 
<https://github.com/grahamperrin/Waterfox/pull/7/files#diff-df8dc4c48927e0bc43931d04bb5b9d9aR161>, 
should that line be left as was?

  #[deny(missing_docs)]

(No exclamation mark.)