Building (deleted) Waterfox 56.2.8: error: missing documentation for macro

[Charlie Li]

On 17/03/2019 12:25, Jan Beich wrote:
> Graham Perrin writes:
> 
>> error: missing documentation for macro
>>    --> 
>> /wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/style_traits/values.rs:341:1
>>     |
>> 341 | macro_rules! define_css_keyword_enum {
>>     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>     |
>> note: lint level defined here
>>    --> 
>> /wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/style_traits/lib.rs:12:22
>>     |
>> 12  | #![deny(unsafe_code, missing_docs)]
>>     |                      ^^^^^^^^^^^^
> 
> Looks like a regression from Rust 1.33 update.
> 
> Either remove missing_docs from #![deny(...)] lines (or lines themselves)
> for each one that triggers error (no need to bother with unused ones) or
> add MOZ_OPTIONS+=--disable-stylo to Makefile.local.
> 
> www/firefox-esr et al. simply backported upstream fixes for warnings to
> avoid having to maintain workarounds forever. Rebasing those against
> very old Stylo code isn't worth the effort.
> 
I simply followed the tip given in Mozilla bug 1521249 (remove
`#![deny(missing_docs)]`), and have been running with it since we
updated our lang/rust to 1.33:
https://bugzilla.mozilla.org/show_bug.cgi?id=1521249#c36

Mozilla upstream are concerned about keeping compatibility with older
rust, especially for their ESR. Since we only ship the latest version of
rust at a time, we don't have to worry about that sort of compatibility,
so backport away.

-- 
Charlie Li
…nope, still don't have an exit line.

(This email address is for mailing list use; replace local-part with
vishwin for off-list communication if possible)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-gecko/attachments/20190317/56991b8b/attachment.sig>