CFD: additions to the PR submission article

Simon L. Nielsen simon at nitro.dk
Tue Apr 12 18:38:22 UTC 2005


On 2005.04.11 04:40:42 -0500, Mark Linimon wrote:
> On Mon, 11 Apr 2005, Simon L. Nielsen wrote:
> 
> > > +      </listitem>
> > > +
> > 
> > No need for an empty line here.
> 
> Hmm, then the style is wrong elsewhere in the article.

That sounds likely.  It's not very important, I just notice things
like that when I read a patch :-).

> > > +    <para>Then you should ascertain whether or not the problem is
> > > +      timely.  There are few things
> > 
> > This line could be made longer.
> 
> Weak attempt at a diff reduction on the next line.  OTOH since I
> moved the block that that line was in to make the emphasis clearer,
> it may not make any difference.

When the text is moved I don't think it it helps much to preserve old
lines, but I don't know if it makes a difference for translators.

> > > +      <ulink url="http://www.freebsd.org/security/">list of supported
> > 
> > s/freebsd.org/FreeBSD.org/
> 
> Also wrong elsewhere IIRC.
> 
> I can make these suggested changes when I commit, and then go back and
> fix the other ones in a separate checkin to make them consistent.

That would be great!

-- 
Simon L. Nielsen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-doc/attachments/20050412/ae506342/attachment.sig>


More information about the freebsd-doc mailing list