Error: Failed to spawn GNU rlog

[Bernd Groh]

Here's the fix:

sub getDirLogs($$@) {
       my ($cvsroot, $dirname, @otherFiles) = @_;
       my ($state, $otherFiles, $tag, $file, $date, $branchpoint, $branch,
           $log);
       my ($rev, $revision, $revwanted, $filename, $head, $author);
                                                                              
       $tag = $input{only_with_tag};
                                                                              
       my ($DirName) = $cvsroot . '/' . $where;
       my (@files, @filetags);
                                                                              
       # added new array to store files initially
       my (@allfiles);
                                                                              
       my $fh = do { local (*FH); };
                                                                              
       push (@allfiles, &safeglob($DirName . '*,v'));
       push (@allfiles, &safeglob($DirName . 'Attic/*,v'))
          if (!$input{'hideattic'});
                                                                              
       foreach my $file (@otherFiles) {
               push (@allfiles, $DirName . $file);
       }
                                                                              
       # just execute rlog with the files we have read access to
       # (i'm sure there's an easier way than actually having to
       #  open the file, but I can't think of it at the moment *l*)
       foreach my $file (@allfiles) {
               if (-r $file) {
                       push (@files, $file);
               }
       }
                                                                              
       # just execute rlog if there are any files
       if ($#files < 0) {
               return;
       }

       # this will now also ensure that rlog is not called on any
       # files it really shouldn't be
       # after this point, code remains the same
...

This will now simply not display any files you do not have 
read-permissions on. Adding an according error-message later on might be 
a good option.

Cheers,
Bernd

-- 
Disclaimer: http://apac.redhat.com/disclaimer