svn commit: r301394 - head [If X_COMPILER_TYPE is defined, do not use it, otherwise use it?]
Bryan Drewery
bdrewery at FreeBSD.org
Sat Jun 4 17:38:29 UTC 2016
On 6/4/2016 10:35 AM, Mark Millard wrote:
> From the commit report:
>
>> +.if defined(X_COMPILER_TYPE)
>> CROSSENV+= COMPILER_VERSION=${COMPILER_VERSION} \
>> COMPILER_TYPE=${COMPILER_TYPE} \
>> COMPILER_FREEBSD_VERSION=${COMPILER_FREEBSD_VERSION}
>
> This does not use X_COMPILER_TYPE when it is defined.
>
>> +.else
>> +CROSSENV+= COMPILER_VERSION=${X_COMPILER_VERSION} \
>> + COMPILER_TYPE=${X_COMPILER_TYPE} \
>> + COMPILER_FREEBSD_VERSION=${X_COMPILER_FREEBSD_VERSION}
>
> This tries to use the undefined X_COMPILER_TYPE.
>
>> +.endif
>
>
>
> Overall:
>
> A not seems to be missing or instead the nested code blocks need to be swapped.
>
I'm an idiot, thanks.
--
Regards,
Bryan Drewery
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20160604/ff922e21/attachment.sig>
More information about the freebsd-current
mailing list