svn commit: r301394 - head [If X_COMPILER_TYPE is defined, do not use it, otherwise use it?]

Mark Millard markmi at dsl-only.net
Sat Jun 4 17:35:48 UTC 2016


From the commit report:

> +.if defined(X_COMPILER_TYPE)
>  CROSSENV+=	COMPILER_VERSION=${COMPILER_VERSION} \
>  		COMPILER_TYPE=${COMPILER_TYPE} \
>  		COMPILER_FREEBSD_VERSION=${COMPILER_FREEBSD_VERSION}

This does not use X_COMPILER_TYPE when it is defined.

> +.else
> +CROSSENV+=	COMPILER_VERSION=${X_COMPILER_VERSION} \
> +		COMPILER_TYPE=${X_COMPILER_TYPE} \
> +		COMPILER_FREEBSD_VERSION=${X_COMPILER_FREEBSD_VERSION}

This tries to use the undefined X_COMPILER_TYPE.

> +.endif



Overall:

A not seems to be missing or instead the nested code blocks need to be swapped.


===
Mark Millard
markmi at dsl-only.net



More information about the freebsd-current mailing list