pidfile_open incorrectly returns EAGAIN when pidfile is locked

[Chuck Swiger]

Hi--

On Mar 14, 2013, at 9:50 AM, John Baldwin wrote:
> On Thursday, March 14, 2013 12:29:58 pm Pawel Jakub Dawidek wrote:

[ ... ]
>> Heh, I did consider that as well, but here you check errno twice,
>> instead of once. Guys, is there anything wrong with the patch I
>> proposed?
> 
> I'm sure the compiler can work that out just fine and it should do whatever
> is most readable to the programmer.  I don't care either way.

Strong +1.  Having the code be correct and readable is much more important
then trying to hand-optimize a single-digit # of integer compares in
startup code that usually runs ~once per process.

(Worrying about and minimizing file access to the pidfile would be a
different matter, since the compiler can't optimize around that...)

Regards,
-- 
-Chuck