pidfile_open incorrectly returns EAGAIN when pidfile is locked

[John Baldwin]

On Thursday, March 14, 2013 12:29:58 pm Pawel Jakub Dawidek wrote:
> On Thu, Mar 14, 2013 at 09:42:40AM -0400, John Baldwin wrote:
> > On Thursday, March 14, 2013 4:44:20 am Pawel Jakub Dawidek wrote:
> > > On Thu, Mar 14, 2013 at 08:28:25AM +0100, Dirk Engling wrote:
> > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > Hash: SHA1
> > > > 
> > > > On 13.03.13 23:08, Pawel Jakub Dawidek wrote:
> > > > 
> > > > > I think I considered something similar at first, but the change I 
> > > > > proposed was optimal, IMHO at the cost of producing pretty large
> > > > > diff, because of indentation change. But to be sure, can you send a
> > > > > patch of your proposed change?
> > > > 
> > > > http://erdgeist.org/arts/software/Code/pidfile.c.diff
> > > 
> > > Right. Your patch assumes EWOULDBLOCK is equal to EAGAIN, which is true
> > > on FreeBSD, but is not portable. Also in case pidptr is NULL you compare
> > > errno three times instead of just one (not a big deal of course, just
> > > something that could be done a bit more optimal:)).
> > 
> > Geeze, why not just add an else.  That's the really short diff:
> 
> Heh, I did consider that as well, but here you check errno twice,
> instead of once. Guys, is there anything wrong with the patch I
> proposed?

I'm sure the compiler can work that out just fine and it should do whatever
is most readable to the programmer.  I don't care either way.

-- 
John Baldwin