PAM passwdqc, strict aliasing, and WARNS

[Lars Engels]

On Sun, Jul 15, 2012 at 12:09:17AM +0200, Dag-Erling Smørgrav wrote:
> "Justin T. Gibbs" <gibbs at FreeBSD.org> writes:
> > Someone who has yet to confess added -Werror to the global CFLAGS
> > (via /etc/make.conf) for one of our systems at work.  Before I
> > figured out that this was the cause of builds failing, I hacked up
> > pam_passwdc to resolve the problem.  This gets the module to
> > WARNS=2, but to go farther, the "logically const" issues with this
> > code will need to be sorted out.
> >
> > Is this change worth committing?  Is this the best way to resolve
> > the strict aliasing issues in this code?
> 
> I really don't like that sort of game.  If you look at other PAM
> consumer code, you'll see that the common idiom is what Jilles
> suggested, i.e. use a temporary variable of the appropriate type.
> 
> That being said, pam_passwdqc should probably be either updated or
> removed.  The version we have is ten years old.

But it still works...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20120715/2d9b3a90/attachment.pgp