PAM passwdqc, strict aliasing, and WARNS

[Dag-Erling Smørgrav]

"Justin T. Gibbs" <gibbs at FreeBSD.org> writes:
> Someone who has yet to confess added -Werror to the global CFLAGS
> (via /etc/make.conf) for one of our systems at work.  Before I
> figured out that this was the cause of builds failing, I hacked up
> pam_passwdc to resolve the problem.  This gets the module to
> WARNS=2, but to go farther, the "logically const" issues with this
> code will need to be sorted out.
>
> Is this change worth committing?  Is this the best way to resolve
> the strict aliasing issues in this code?

I really don't like that sort of game.  If you look at other PAM
consumer code, you'll see that the common idiom is what Jilles
suggested, i.e. use a temporary variable of the appropriate type.

That being said, pam_passwdqc should probably be either updated or
removed.  The version we have is ten years old.

DES
-- 
Dag-Erling Smørgrav - des at des.no