[patch] corrupt memstat_kvm_malloc(3) output and dtrace

[Ben Kelly]

Hi all,

While debugging a problem recently with Alexander Leidinger we noticed  
that crashinfo(8) was producing corrupt vmstat -m output.  After doing  
some digging it appears that memstat_kvm_malloc(3) might have been  
broken by this commit:

   http://svn.freebsd.org/viewvc/base?view=revision&revision=179222

The problem is that memstat_kvm_malloc(3) assumes that  
malloc_type_internal starts with an array of malloc_types_stats  
structures.  This assumption is no longer true, though, as mti_probes  
was inserted at the start of the structure.

It appears that this (untested) patch might fix the problem:

   http://www.wanderview.com/svn/public/misc/zfs/vmstat_kvm_malloc.diff

I'm not very familiar with dtrace, though.  Does anyone know if this  
would cause problems?

Thanks.

- Ben