Retiring WITH_INSTALL_AS_USER

[Warner Losh]

On Oct 22, 2014, at 10:29 PM, Simon J. Gerraty <sjg at juniper.net> wrote:

> Warner Losh <imp at bsdimp.com> wrote:
> 
>> I’d like to retire WITH_INSTALL_AS_USER. Brooks’ NO_ROOT (which I’m
>> also converting to WITHOUT_ROOT) is much better. WITH_INSTALL_AS_USER
> 
> Hmm I don't see anything in share/mk for NO_ROOT.
> I see some tweaks in src/Makefile.inc1 though.
> Is there more somewhere?

Makefile.inc1 and etc/Makefile. It will woo be in share/mk.

>> is broken. First, it requites you also define NO_FSCHG. Second, any
>> Makefile that overrides the owner and also has to include src.opts.mk
>> early to check options fails. It has been broken for some time (even
>> before my conversion to src.opts.mk, since bsd.own.mk included earlier
> 
> Sorry I hadn't noticed - but I think the only place we seriously
> exercise it is in src/include and etc for distrib-dirs.
> Losing the ablity to do that would be a problem.

If it is in the tree, it needs to work. It is broken in about a dozen places
now. Perhaps not the ones that you use.

>> Comments?
> 
> My only concern would be if it somehow depends on top-level build it
> won't work for those of us who do that or at least not using
> Makefile.inc1
> 
> What can I look at to better understand NO_ROOT ?

Makefile.inc1 is the only place it is documented right now. NO_ROOT creates a METADATA file for the attributes of the file and does simple copies instead. This lets you build entirely as an unpriv’d user, but still use makefs to get a filesystem with the proper attributes. In many ways it is what you want, and you could get what you want by specifying /dev/null for that METADATA if it were more tightly coupled.

Warner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/freebsd-arch/attachments/20141023/c1a27eaa/attachment.sig>