Retiring WITH_INSTALL_AS_USER

[Simon J. Gerraty]

Warner Losh <imp at bsdimp.com> wrote:

> I’d like to retire WITH_INSTALL_AS_USER. Brooks’ NO_ROOT (which I’m
> also converting to WITHOUT_ROOT) is much better. WITH_INSTALL_AS_USER

Hmm I don't see anything in share/mk for NO_ROOT.
I see some tweaks in src/Makefile.inc1 though.
Is there more somewhere?

> is broken. First, it requites you also define NO_FSCHG. Second, any
> Makefile that overrides the owner and also has to include src.opts.mk
> early to check options fails. It has been broken for some time (even
> before my conversion to src.opts.mk, since bsd.own.mk included earlier

Sorry I hadn't noticed - but I think the only place we seriously
exercise it is in src/include and etc for distrib-dirs.
Losing the ablity to do that would be a problem.

> Comments?

My only concern would be if it somehow depends on top-level build it
won't work for those of us who do that or at least not using
Makefile.inc1

What can I look at to better understand NO_ROOT ?