kern/112544: [acpi] [patch] Add High Precision Event Timer Driver for userland timer facility

Takeharu KATO takeharu1219 at ybb.ne.jp
Tue May 22 16:30:08 UTC 2007


Hi

Thank you for your review, I'll fix following issue.

Marius Nuennerich wrote:
>  I haven't read the whole patch yet.
>  To me line 164 (of the first patch file) seems bogus. It tries to do
>  the right thing (read-modify-write) but actually does not.
>  HPET_OFFSET_ENABLE is the offset in the hpet datastructure. 
>  
>  Should be like this:
>  val = bus_read_4(sc->mem_res, HPET_OFFSET_ENABLE);
>  bus_write_4(sc->mem_res, HPET_OFFSET_ENABLE, val | 1);
>  
>  And 1 should better HPET_ENABLE_ENABLE.
>  
>  Line 133 of the same patch does not even try to do a read-modify-write.
>  However the documentation is clear that it should.
>  
>  This all applies to the driver in -current (1.8) as well.
>  




More information about the freebsd-acpi mailing list