git: 5b7c17856512 - main - git hooks: Rework authorship instructions.

[Mathieu Arnold]

On Thu, Apr 22, 2021 at 12:10:26PM +0200, Michael Gmelin wrote:
> 
> 
> > On 22. Apr 2021, at 12:08, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> > 
> > On Thu, Apr 22, 2021 at 09:52:19AM +0000, Mathieu Arnold wrote:
> >> ...
> >> diff --git a/.hooks/prepare-commit-msg b/.hooks/prepare-commit-msg
> >> @@ -44,6 +44,9 @@ $(awk '1;/^#$/{exit}' "$1")
> >> # <then a blank line>
> >> #                                                         72 columns --|
> >> #
> >> +# Do not add a Submitted by line.  If someone besides the committer sent in the
> >> +# change, the commit author should be set using \`git commit --author\`.
> >> +#
> > 
> > This doesn't seem right.  "Submitted by" can be a list, not a single name.
> > Also, I rarely commit submitted work verbatim, so technically the author
> > is me 99% of the time, yet it would be appropriate to give attribution to
> > the original submitter, esp. if there is no PR number (private submission).
> > 
> 
> I agree that author should only be used if a submission is applied unaltered (pull request/git patch).

Submitted by has always been for submission that was unaltered (or only
slightly altered) if it was only the basis of the work, then "submitted
by" is not to be used, in those cases, reported by is the correct
choice.

As for the multiple authors, do multiple commits, stop piling up stuff
in only one commit.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/dev-commits-ports-all/attachments/20210422/59cf2f9e/attachment.sig>