git: 5b7c17856512 - main - git hooks: Rework authorship instructions.
Michael Gmelin
grembo at freebsd.org
Thu Apr 22 10:10:39 UTC 2021
> On 22. Apr 2021, at 12:08, Alexey Dokuchaev <danfe at freebsd.org> wrote:
>
> On Thu, Apr 22, 2021 at 09:52:19AM +0000, Mathieu Arnold wrote:
>> ...
>> diff --git a/.hooks/prepare-commit-msg b/.hooks/prepare-commit-msg
>> @@ -44,6 +44,9 @@ $(awk '1;/^#$/{exit}' "$1")
>> # <then a blank line>
>> # 72 columns --|
>> #
>> +# Do not add a Submitted by line. If someone besides the committer sent in the
>> +# change, the commit author should be set using \`git commit --author\`.
>> +#
>
> This doesn't seem right. "Submitted by" can be a list, not a single name.
> Also, I rarely commit submitted work verbatim, so technically the author
> is me 99% of the time, yet it would be appropriate to give attribution to
> the original submitter, esp. if there is no PR number (private submission).
>
I agree that author should only be used if a submission is applied unaltered (pull request/git patch).
-m
> ./danfe
More information about the dev-commits-ports-all
mailing list