cvs commit: src/lib/libc/i386/net htonl.S ntohl.S

[Ruslan Ermilov]

On Mon, Oct 18, 2004 at 12:54:58PM -0700, David O'Brien wrote:
> On Mon, Oct 18, 2004 at 10:24:17PM +0300, Ruslan Ermilov wrote:
> > On Mon, Oct 18, 2004 at 07:00:47PM +0000, David O'Brien wrote:
> > > On Mon, Oct 18, 2004 at 09:03:20PM +0300, Ruslan Ermilov wrote:
> > > > On Mon, Oct 18, 2004 at 10:45:11AM -0700, David O'Brien wrote:
> > > > > On Mon, Oct 18, 2004 at 08:35:16PM +0300, Ruslan Ermilov wrote:
> > > > > > On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrote:
> > > > > > > obrien      2004-10-18 17:19:36 UTC
> > > > > > >   FreeBSD src repository
> > > > > > >   Modified files:
> > > > > > >     lib/libc/i386/net    htonl.S ntohl.S 
> > > > > > >   Log:
> > > > > > >   Sync with sys/i386/include/endian.h: use the single instruction 'bswap'.
> ..
> > > Taking 
> > >   Revision  Changes    Path
> > >   1.10      +4 -0      src/lib/libc/i386/net/htonl.S
> > >   1.10      +4 -0      src/lib/libc/i386/net/ntohl.S
> > > 
> > > specifically what patch do you suggest that we used in cases like this
> > > rather than #ifdef I386_CPU".  And how to use it?  That is one in which
> > > someone checks out the source and wants to build a userland that is
> > > usable on an I386 machine.
> > 
> > I thought I already made it clear, seems not.
> 
> Not clear enough that I was 100% sure how to make you happy.
> 
Not me, but our i386 users.  ;)

> I386_CPU
> needs to be userland land global so we establish the a normal way of
> doing this.  What do you think of this patch?
> 
> Index: /usr/src/share/mk/bsd.cpu.mk
> ===================================================================
> RCS file: /home/ncvs/src/share/mk/bsd.cpu.mk,v
> retrieving revision 1.44
> diff -u -r1.44 bsd.cpu.mk
> --- /usr/src/share/mk/bsd.cpu.mk	17 Oct 2004 05:19:45 -0000	1.44
> +++ /usr/src/share/mk/bsd.cpu.mk	18 Oct 2004 19:51:17 -0000
> @@ -100,6 +100,9 @@
>  .  else
>  _ICC_CPUCFLAGS =
>  .  endif # ICC on 'i386'
> +.  if ${CPUTYPE} == "i386"
> +CFLAGS += -DI386_CPU
> +.  endif
>  . elif ${MACHINE_ARCH} == "alpha"
>  _CPUCFLAGS = -mcpu=${CPUTYPE}
>  . elif ${MACHINE_ARCH} == "amd64"
> 
That's what I suggested except that you put it directly to CFLAGS.
I agree that putting it directly to CFLAGS is more correct.  Yes,
I like this patch.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20041018/84f9825e/attachment.bin