cvs commit: src/lib/libc/i386/net htonl.S ntohl.S

[David O'Brien]

On Mon, Oct 18, 2004 at 10:24:17PM +0300, Ruslan Ermilov wrote:
> On Mon, Oct 18, 2004 at 07:00:47PM +0000, David O'Brien wrote:
> > On Mon, Oct 18, 2004 at 09:03:20PM +0300, Ruslan Ermilov wrote:
> > > On Mon, Oct 18, 2004 at 10:45:11AM -0700, David O'Brien wrote:
> > > > On Mon, Oct 18, 2004 at 08:35:16PM +0300, Ruslan Ermilov wrote:
> > > > > On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrote:
> > > > > > obrien      2004-10-18 17:19:36 UTC
> > > > > >   FreeBSD src repository
> > > > > >   Modified files:
> > > > > >     lib/libc/i386/net    htonl.S ntohl.S 
> > > > > >   Log:
> > > > > >   Sync with sys/i386/include/endian.h: use the single instruction 'bswap'.
..
> > Taking 
> >   Revision  Changes    Path
> >   1.10      +4 -0      src/lib/libc/i386/net/htonl.S
> >   1.10      +4 -0      src/lib/libc/i386/net/ntohl.S
> > 
> > specifically what patch do you suggest that we used in cases like this
> > rather than #ifdef I386_CPU".  And how to use it?  That is one in which
> > someone checks out the source and wants to build a userland that is
> > usable on an I386 machine.
> 
> I thought I already made it clear, seems not.

Not clear enough that I was 100% sure how to make you happy.  I386_CPU
needs to be userland land global so we establish the a normal way of
doing this.  What do you think of this patch?

Index: /usr/src/share/mk/bsd.cpu.mk
===================================================================
RCS file: /home/ncvs/src/share/mk/bsd.cpu.mk,v
retrieving revision 1.44
diff -u -r1.44 bsd.cpu.mk
--- /usr/src/share/mk/bsd.cpu.mk	17 Oct 2004 05:19:45 -0000	1.44
+++ /usr/src/share/mk/bsd.cpu.mk	18 Oct 2004 19:51:17 -0000
@@ -100,6 +100,9 @@
 .  else
 _ICC_CPUCFLAGS =
 .  endif # ICC on 'i386'
+.  if ${CPUTYPE} == "i386"
+CFLAGS += -DI386_CPU
+.  endif
 . elif ${MACHINE_ARCH} == "alpha"
 _CPUCFLAGS = -mcpu=${CPUTYPE}
 . elif ${MACHINE_ARCH} == "amd64"

-- 
-- David  (obrien at FreeBSD.org)