cvs commit: src/sys/security/mac_mls mac_mls.c

[Bruce Evans]

On Fri, 30 May 2003, Ruslan Ermilov wrote:

> On Fri, May 30, 2003 at 02:25:10PM -0400, John Baldwin wrote:
> > Can someone make module builds use the same warning flags and
> > settings as kernel builds please?  This same scenario has happened
> > numerous times now.
> >
> This is not easy.  For the kernel build, we have NORMAL_C and
> NORMAL_C_NOWERROR (the former includes WERROR?= -Werror).
> There are lot of files in sys/conf/files* that are marked with
> "nowerror", and I'm sure they will break to compile as modules
> with this patch, e.g., the acpi module has lot of files with
> warnings:

Not a lot, actually.  There are 21 acpi files and 17 non-acpi files with
nowerror.  The acpi errors are less numerous than they used.  About half
of the other 17 are for unmaintained drivers and the other half are
not needed or otherwise bogus.

> %%%
> Index: kern.mk
> ===================================================================
> RCS file: /home/ncvs/src/sys/conf/kern.mk,v
> retrieving revision 1.34
> diff -u -r1.34 kern.mk
> --- kern.mk	3 May 2003 18:05:56 -0000	1.34
> +++ kern.mk	30 May 2003 19:57:00 -0000
> @@ -9,6 +9,8 @@
>  CWARNFLAGS?=	-Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes \
>  		-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual \
>  		-fformat-extensions -std=c99
> +WERROR?=	-Werror
> +
>  #
>  # The following flags are next up for working on:
>  #	-W

Style bug: separation of the -W options and comments by putting a non- -W
option in the middile.

The comment at the beginning of kern.mk was intended to apply to the whole
file (the file should contain only warning options).  This was broken in
rev.1.11.

Bruce