cvs commit: src/sys/nfsclient nfs_lock.c

[Robert Watson]

rwatson     2003/05/30 10:15:56 PDT

  FreeBSD src repository

  Modified files:
    sys/nfsclient        nfs_lock.c 
  Log:
  rpc.lockd stability workaround: remove PCATCH from the tsleep() in
  nfs_lock.c.  Right now, if we permit a signal to interrupt the sleep,
  we will slip the lock and no process on that client, the server, or
  any other client will be able to acquire the lock.  This can happen,
  for example, if a user hits Ctrl-C or Ctrl-T while a process is
  waiting for the lock.  By removing PCATCH, we prevent that from
  happening, at the cost of not permitting a user-requested lock abort:
  also nasty.  However, a user interface bug might be preferable to a
  serious semantic bug, so we go with that for now.
  
  We need to teach the rpc.lockd/kernel protocol how to abort lock
  requests, and rpc.lockd how to handle aborted lock requests; patches
  for the kernel bit are floating around, but no rpc.lockd bit yet.
  
  Approved by:    re (scottl)
  
  Revision  Changes    Path
  1.36      +1 -1      src/sys/nfsclient/nfs_lock.c