cvs commit: ports/archivers/gzip Makefile ports/archivers/ucl Makefile ports/archivers/dact Makefile ports/archivers/star Makefile ports/archivers/arj Makefile ports/archivers/tardy ...

[Florent Thoumie]

Le Monday 11 April 2005 à 11:44 -0700, Kris Kennaway a écrit :
> On Mon, Apr 11, 2005 at 08:36:51PM +0200, Florent Thoumie wrote:
> > Le Monday 11 April 2005 ? 11:21 -0700, Kris Kennaway a ?crit :
> > > On Mon, Apr 11, 2005 at 08:15:03PM +0200, Florent Thoumie wrote:
> > > > Le Monday 11 April 2005 ? 11:08 -0700, David O'Brien a ?crit :
> > > > > On Mon, Apr 11, 2005 at 01:42:11AM -0700, Kris Kennaway wrote:
> > > > > > On Mon, Apr 11, 2005 at 08:04:41AM +0000, David E. O'Brien wrote:
> > > > > > > obrien      2005-04-11 08:04:41 UTC
> > > > > > > 
> > > > > > >   FreeBSD ports repository
> > > > > > > 
> > > > > > >   Modified files:
> > > > > > >     archivers/gzip       Makefile 
> > > > > > >     archivers/ucl        Makefile 
> > > > > > 
> > > > > > Please back this out.
> > > > > 
> > > > > Will do.
> > > > 
> > > > 	I have fixed almost all ports and ready to commit.
> > > > 
> > > > 	I'd like to be sure not facing portmgr decision to backout the 
> > > > 	commit.
> > > > 
> > > > 	Note: I've already fixed some, haven't seen this mail from Kris.
> > > 
> > > What I'd like is for everything to be backed out except for those
> > > ports that have been since fixed by you and others.  That way your
> > > work isn't undone.
> > 
> > 	They're all fixed, but not all committed.
> > 
> > 	I haven't spent too much time on this, so that's not a big deal
> > 	but as Adam stated, he didn't break much ports in comparison 
> > 	of how many he touched. Plus, the MACHINE_ARCH -> ARCH isn't 
> > 	only style change.
> > 
> > 	Btw, it's up to you.
> 
> The first issue here is timing.  As reminded in my original email
> there are not supposed to be any sweeping commits during the ports
> slush.  The second issue is the amount of breakage that happened here
> due to untested changes and apparent lack of visual review of the diff
> prior to committing.  I believe that most of that will be caught by a
> simple review of the diff, which you've probably completed already.
> I'll be happy for you to commit the rest of the changes after the
> slush ends, but for now we need to go back to a relatively clean
> slate.

	Sure, no problem.

	I'll submit patches to David so he can do this by himself (or 
	I'll do).

-- 
Florent Thoumie
flz at xbsd.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/cvs-ports/attachments/20050411/b3be04fb/attachment.bin