cvs commit: ports/www/apache2

[Oliver Eikemeier]

Clement Laforet wrote:

>>>+#	WITHOUT_ERROR:            Do not install www/error
>>
>>I would make this the default ;-) Honestly: there must be a better
>>name for it. Do we need that many options?
> 
> WITHOUT_ERROR_SAMPLES maybe...
> About the "many options", I can introduce a WITH_CUSTOM_WWW, like WITH_CUSTOM_PROXY.
> WITH_CUSTOM_WWW=	[error|wwwdata|cgi|icons]

I didn't follow the discussion, so excuse me when I say something stupid,
but what I meant is: what are all those options good for? Did someone
request them and do they serve a real purpose?

You add complexity to your Makefile and introduce subtle errors, like

> post-extract:
> 	@${INSTALL_DATA} ${DISTDIR}/${DIST_SUBDIR}/powerlogo.gif ${WRKSRC}/docs/icons/freebsd.gif

even though (WITHOUT|NO)_ICONS is defined.


>>>show-options:
>>>	@${EGREP} '^##' ${.CURDIR}/Makefile | ${SED} 's/##//'
>>
>>Not that I particularly like this, but how about using:
>>	@${SED} -ne 's/^##//p' ${.CURDIR}/Makefile
> 
> Why not... (but it get rid of the header and footer blank line)

I can't see why (but I have to admid that I didn't tested it)

> I have some minor cleaning to add to Makefile.modules
> I'll surely submit PORTREVISION 1 this afternoon.

Don't hurry...