cvs commit: ports/www/apache2

[Clement Laforet]

On Thu, 30 Oct 2003 12:03:58 +0100
Oliver Eikemeier <eikemeier at fillmore-labs.com> wrote:

 
> I can't find any conflicts with the caudium* ports, and www/mini_httpd
> is missing. How about:
<snip> 
my CONFLICTS lines seems to have disappeared when I merge my devel ports
and one in CVS tree. Surely due to dinoex's changes.
Added to TODO list.

> 
> 
> > +#	WITH_PORT                default: 80
> 
> I'm fine with that, even though WITH_HTTP_PORT seems more appealing to
> me.
ok
> 
> > +#	WITHOUT_ERROR:            Do not install www/error
> 
> I would make this the default ;-) Honestly: there must be a better
> name for it. Do we need that many options?
WITHOUT_ERROR_SAMPLES maybe...
About the "many options", I can introduce a WITH_CUSTOM_WWW, like WITH_CUSTOM_PROXY.
WITH_CUSTOM_WWW=	[error|wwwdata|cgi|icons]

> 
> > .if defined(WITH_LDAP)
> > USE_LDAP=	YES
> 
> That doesn't seem to work, it's USE_OPENLDAP as far as I can remember.
yep. where's my head ? :)
 
> 
> > +	@${ECHO}
> > +	@${ECHO_MSG} "*** To see all available knobs, type:  make
> > show-options"+	@${ECHO}
> Mixing ECHO and ECHO_MSG is strange, how about using ECHO here?
remaining of developpement ;-) I was too focused on modules handling :-)
Added to TODO list
 
> > show-options:
> > 	@${EGREP} '^##' ${.CURDIR}/Makefile | ${SED} 's/##//'
> 
> Not that I particularly like this, but how about using:
> 	@${SED} -ne 's/^##//p' ${.CURDIR}/Makefile
Why not... (but it get rid of the header and footer blank line)

I have some minor cleaning to add to Makefile.modules
I'll surely submit PORTREVISION 1 this afternoon.

clem