rclint -- most base files don't pass it?

From: Dan Mahoney (Ports) <freebsd_at_gushi.org>
Date: Fri, 25 Oct 2024 19:59:41 UTC
Hey there all,

When I'm working on ports or systems (either as part of a port I maintain, or for dayjob deployments) I use sysutils/rclint to make sure my rc.d files are in-line with what FreeBSD expects.

That said, I recently tried running it on some of the stuff in base /etc/rc.d (as well as some of my installed ports), and many things don't pass.  Now, this may just be that rclint has newer expectations.

Weirdly, I find fixing this stuff like playing sudoku, oddly gratifying.

If the work were put in to fix these, would it be accepted, or would I just be wasting my time?

-Dan

PS: As a few examples:

# rclint ntpd
Checking ntpd
ERROR:root:[31]: Inline brace in function
ERROR:root:[132]: Inline brace in function
ERROR:root:[140]: Inline brace in function
ERROR:root:[146]: Inline brace in function
ERROR:root:[152]: Inline brace in function
ERROR:root:[167]: Inline brace in function
ERROR:root:[209]: Inline brace in function
ERROR:root:[29]: Order of rc file incorrect
ERROR:root:[31]: Orphaned line
ERROR:root:[32]: Orphaned line
ERROR:root:[33]: Orphaned line
ERROR:root:Error threshold reached-- further errors are unlikely to be helpful.  Fix the errors and rerun.  The -k option will cause rclint to continue for as many errors as it finds.  Try rerunning with -v option for extra details.
# rclint swap
Checking swap
ERROR:root:[16]: Order of rc file incorrect
ERROR:root:[11]: Do not quote values unless necessary
ERROR:root:[14]: Do not quote values unless necessary
# rclint cron
Checking cron
ERROR:root:[18]: Order of rc file incorrect
ERROR:root:[19]: Orphaned line
ERROR:root:[20]: Orphaned line
ERROR:root:[21]: Orphaned line
ERROR:root:[22]: Orphaned line
ERROR:root:[12]: Do not quote values unless necessary
ERROR:root:[14]: Do not quote values unless necessary