From nobody Fri Oct 25 19:59:41 2024 X-Original-To: questions@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XZttD2kyvz5b600 for ; Fri, 25 Oct 2024 20:00:04 +0000 (UTC) (envelope-from freebsd@gushi.org) Received: from prime.gushi.org (prime.gushi.org [IPv6:2620:137:6000:10::142]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "prime.gushi.org", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XZttB5lmtz4l2Z for ; Fri, 25 Oct 2024 20:00:02 +0000 (UTC) (envelope-from freebsd@gushi.org) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gushi.org header.s=prime2014 header.b=u1AfAg0C; spf=pass (mx1.freebsd.org: domain of freebsd@gushi.org designates 2620:137:6000:10::142 as permitted sender) smtp.mailfrom=freebsd@gushi.org; dmarc=pass (policy=none) header.from=gushi.org Received: from smtpclient.apple ([IPv6:2001:500:6b:200:8000:0:0:2dc]) (authenticated bits=0) by prime.gushi.org (8.18.1/8.18.1) with ESMTPSA id 49PJxw2T066706 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 25 Oct 2024 19:59:59 GMT (envelope-from freebsd@gushi.org) DKIM-Filter: OpenDKIM Filter v2.10.3 prime.gushi.org 49PJxw2T066706 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gushi.org; s=prime2014; t=1729886400; bh=Dbi5FLf7hGJAoRifnwK+uwaBmYtcooaF3VVmtOsebOw=; h=From:Subject:Date:To; z=From:=20"Dan=20Mahoney=20(Ports)"=20|Subject:= 20rclint=20--=20most=20base=20files=20don't=20pass=20it?|Date:=20F ri,=2025=20Oct=202024=2012:59:41=20-0700|To:=20questions=20; b=u1AfAg0CAUDvXLfIXAmXq114BMK7lfjK/9urHZJ7CK8cjhLO/1bnU8JfiYsTZ4AJR 5hUVvdOpI57ujHldwO/QC8K9E22oYwxNhGaL4xj6XBtxAHFIEUrH1nU318yHVV+fwV zY1zVMZkW+9u99A72cQEoXkCiAKDT0lexnxZPqtKK9sNMweb12jTMrYHhBkr8oJN4v hVfz/j1aX2h8tvGby7HGjYP4CI8XzMZKGmUHFOzEHCxgobg3x/zFn3XrLK4wpPMPn9 rSVQZlMN6KJ7e6nuFCuaDyxSkEBRioQkXNB+iu1NTu1xSB8B4Hworj6KA3V3p+F0lY kgqAWvjjc5KUQ== X-Authentication-Warning: prime.gushi.org: Host [IPv6:2001:500:6b:200:8000:0:0:2dc] claimed to be smtpclient.apple From: "Dan Mahoney (Ports)" Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable List-Id: User questions List-Archive: https://lists.freebsd.org/archives/freebsd-questions List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-questions@freebsd.org Sender: owner-freebsd-questions@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.200.121\)) Subject: rclint -- most base files don't pass it? Message-Id: Date: Fri, 25 Oct 2024 12:59:41 -0700 To: questions X-Mailer: Apple Mail (2.3826.200.121) X-Spamd-Result: default: False [-5.60 / 15.00]; DWL_DNSWL_MED(-2.00)[gushi.org:dkim]; NEURAL_HAM_LONG(-1.00)[-1.000]; SUBJECT_ENDS_QUESTION(1.00)[]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; DMARC_POLICY_ALLOW(-0.50)[gushi.org,none]; R_SPF_ALLOW(-0.20)[+mx]; R_DKIM_ALLOW(-0.20)[gushi.org:s=prime2014]; RCVD_IN_DNSWL_MED(-0.20)[2620:137:6000:10::142:from]; MIME_GOOD(-0.10)[text/plain]; ONCE_RECEIVED(0.10)[]; MIME_TRACE(0.00)[0:+]; TO_DN_ALL(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:393507, ipnet:2620:137:6000::/44, country:US]; PREVIOUSLY_DELIVERED(0.00)[questions@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[gushi.org:+]; MLMMJ_DEST(0.00)[questions@freebsd.org]; APPLE_MAILER_COMMON(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_XAW(0.00)[] X-Rspamd-Queue-Id: 4XZttB5lmtz4l2Z X-Spamd-Bar: ----- Hey there all, When I'm working on ports or systems (either as part of a port I = maintain, or for dayjob deployments) I use sysutils/rclint to make sure = my rc.d files are in-line with what FreeBSD expects. That said, I recently tried running it on some of the stuff in base = /etc/rc.d (as well as some of my installed ports), and many things don't = pass. Now, this may just be that rclint has newer expectations. Weirdly, I find fixing this stuff like playing sudoku, oddly gratifying. If the work were put in to fix these, would it be accepted, or would I = just be wasting my time? -Dan PS: As a few examples: # rclint ntpd Checking ntpd ERROR:root:[31]: Inline brace in function ERROR:root:[132]: Inline brace in function ERROR:root:[140]: Inline brace in function ERROR:root:[146]: Inline brace in function ERROR:root:[152]: Inline brace in function ERROR:root:[167]: Inline brace in function ERROR:root:[209]: Inline brace in function ERROR:root:[29]: Order of rc file incorrect ERROR:root:[31]: Orphaned line ERROR:root:[32]: Orphaned line ERROR:root:[33]: Orphaned line ERROR:root:Error threshold reached-- further errors are unlikely to be = helpful. Fix the errors and rerun. The -k option will cause rclint to = continue for as many errors as it finds. Try rerunning with -v option = for extra details. # rclint swap Checking swap ERROR:root:[16]: Order of rc file incorrect ERROR:root:[11]: Do not quote values unless necessary ERROR:root:[14]: Do not quote values unless necessary # rclint cron Checking cron ERROR:root:[18]: Order of rc file incorrect ERROR:root:[19]: Orphaned line ERROR:root:[20]: Orphaned line ERROR:root:[21]: Orphaned line ERROR:root:[22]: Orphaned line ERROR:root:[12]: Do not quote values unless necessary ERROR:root:[14]: Do not quote values unless necessary