Re: Blacklistd Issues - Problem Identified

Michael, hello.

On 18 Apr 2023, at 12:21, Michael Grimm wrote:

>> However, that would be my first time with the FreeBSD sources.  Is there a standard process for this?
>
>  I am not an expert either, but I would first of all open a PR. Their you can publish your patches against sources. Someone else will later commit your patch if accepted.

Sounds good....

>> I notice that the blacklistd sources aren't in <https://github.com/freebsd/freebsd-src/tree/main/usr.sbin/blacklistd> , so I'm stuck at step 1.
>
>  The sources are at:
>
>  /usr/src/contrib/blacklist
>
>  In /usr/src/contrib/blacklist/bin you'll find blacklistd.conf and the config files in /usr/src/contrib/blacklist/etc

I can see the sources if I include src when installing from dvd1.  So far so good...

I think I may need to be pointed towards some further reading, though.  In (a copy of) /usr/src/contrib/blacklist I try 'make', and that doesn't work (illustrated below) because there's clearly a -I missing (ie, I'm doubtless doing this in the wrong place).

Looking at [1], /usr/src/Makefile, and /usr/src/UPDATING, I'm getting the impression that the only documented process is 'make world' or 'make buildworld'.  Would that be right?  Even in this simple case where the sources are associated with the userland on the same install image?

Thanks for any pointers,

Norman


[1] https://docs.freebsd.org/en/books/handbook/cutting-edge/#makeworld


%  make
===> lib (all)
cc  -O2 -pipe -fno-common   -g -MD  -MF.depend.bl.o -MTbl.o -std=gnu99 -Wno-format-zero-length -fstack-protector-strong -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-error=unused-but-set-variable  -Qunused-arguments    -c bl.c -o bl.o
bl.c:60:10: fatal error: 'bl.h' file not found
#include "bl.h"
         ^~~~~~
1 error generated.
*** Error code 1

Stop.
make[1]: stopped in /usr/src/contrib/blacklist-mod/lib
*** Error code 1

Stop.
make: stopped in /usr/src/contrib/blacklist-mod


-- 
Norman Gray  :  https://nxg.me.uk