From nobody Tue Apr 18 16:43:01 2023 X-Original-To: questions@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q18r36hbqz45L6v for ; Tue, 18 Apr 2023 16:43:31 +0000 (UTC) (envelope-from gray@nxg.name) Received: from mx2.mythic-beasts.com (mx2.mythic-beasts.com [IPv6:2a00:1098:0:82:1000:0:2:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q18r3569Kz3y8J for ; Tue, 18 Apr 2023 16:43:31 +0000 (UTC) (envelope-from gray@nxg.name) Authentication-Results: mx1.freebsd.org; none Received: by mailhub-hex-d.mythic-beasts.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pooQT-00AFnv-8B; Tue, 18 Apr 2023 17:43:29 +0100 From: Norman Gray To: Michael Grimm Cc: questions@freebsd.org, Doug Hardie Subject: Re: Blacklistd Issues - Problem Identified Date: Tue, 18 Apr 2023 17:43:01 +0100 X-Mailer: MailMate (1.14r5818) Message-ID: In-Reply-To: References: <8B1C1DCE-75CA-4CE9-A589-329519FB792E@sermon-archive.info> <4E4A4B99-D8DF-4C5C-9700-C56F354A9991@sermon-archive.info> <24171551-4181-49C8-B1DE-2C3D9A00DC4C@sermon-archive.info> <6BD45EAE-D626-4B16-8C24-197FFE34E601@ellael.org> <8FEE687C-E342-49CF-B3D9-118D7ADB84AA@nxg.name> List-Id: User questions List-Archive: https://lists.freebsd.org/archives/freebsd-questions List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-questions@freebsd.org X-BeenThere: freebsd-questions@freebsd.org MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-BlackCat-Spam-Score: 24 X-Spam-Status: No, score=2.4 X-Rspamd-Queue-Id: 4Q18r3569Kz3y8J X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:44684, ipnet:2a00:1098::/32, country:GB] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N Michael, hello. On 18 Apr 2023, at 12:21, Michael Grimm wrote: >> However, that would be my first time with the FreeBSD sources. Is the= re a standard process for this? > > I am not an expert either, but I would first of all open a PR. Their y= ou can publish your patches against sources. Someone else will later comm= it your patch if accepted. Sounds good.... >> I notice that the blacklistd sources aren't in , so I'm stuck at step 1.= > > The sources are at: > > /usr/src/contrib/blacklist > > In /usr/src/contrib/blacklist/bin you'll find blacklistd.conf and the = config files in /usr/src/contrib/blacklist/etc I can see the sources if I include src when installing from dvd1. So far= so good... I think I may need to be pointed towards some further reading, though. I= n (a copy of) /usr/src/contrib/blacklist I try 'make', and that doesn't w= ork (illustrated below) because there's clearly a -I missing (ie, I'm dou= btless doing this in the wrong place). Looking at [1], /usr/src/Makefile, and /usr/src/UPDATING, I'm getting the= impression that the only documented process is 'make world' or 'make bui= ldworld'. Would that be right? Even in this simple case where the sourc= es are associated with the userland on the same install image? Thanks for any pointers, Norman [1] https://docs.freebsd.org/en/books/handbook/cutting-edge/#makeworld % make =3D=3D=3D> lib (all) cc -O2 -pipe -fno-common -g -MD -MF.depend.bl.o -MTbl.o -std=3Dgnu99 = -Wno-format-zero-length -fstack-protector-strong -Wsystem-headers -Werror= -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmis= sing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings= -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Wne= sted-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -= Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-strin= g-plus-int -Wno-unused-const-variable -Wno-error=3Dunused-but-set-variabl= e -Qunused-arguments -c bl.c -o bl.o bl.c:60:10: fatal error: 'bl.h' file not found #include "bl.h" ^~~~~~ 1 error generated. *** Error code 1 Stop. make[1]: stopped in /usr/src/contrib/blacklist-mod/lib *** Error code 1 Stop. make: stopped in /usr/src/contrib/blacklist-mod -- = Norman Gray : https://nxg.me.uk