[Bug 281847] devel/py-Automat: Update to 24.8.1

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281847

--- Comment #4 from John W. O'Brien <john@saltant.com> ---
(In reply to Vladimir Druzenko from comment #1)

Thank you for taking this PR and committing the patch.

As for PORTVERSION vs. DISTVERSION, I don't understand why you changed this. I
didn't choose arbitrarily. I tried to interpret applicable information.

-- What does bsd.port.mk say?

...
# PORTVERSION   - Version of software.  Mandatory when no DISTVERSION is given.
...
# DISTVERSION   - Vendor version of the distribution.
#                                 Default: ${PORTVERSION}
...

While this is ambiguous, b.p.m lists PORTVERSION second overall, just after
PORTNAME, and DISTVERSION defaults to PORTVERSION while there is no stated
default for PORTVERSION. Both of these imply that PORTVERSION is the primary
designation, and that there may be a minority of cases in which DISTVERSION
needs to be overridden or used instead of PORTVERSION. I cannot recall a case
with any port I have ever touched when setting PORTVERSION resulted in an
undesired outcome.

-- What do people actually use?

% find /usr/ports/ -depth 3 -name Makefile \
    | xargs grep -Eoh "^(PORT|DIST)VERSION=" \
    | sort \
    | uniq -c \
    | sort -rn
22486 PORTVERSION=
9024 DISTVERSION=
% find /usr/ports/ -depth 3 -name Makefile \
    | xargs grep -Eh "^DISTNAME=" \
    | grep -Eo "(PORT|DIST)VERSION" \
    | sort \
    | uniq -c \
    | sort -rn
2488 PORTVERSION
1122 DISTVERSION

The use of PORTVERSION is more than twice as frequent than DISTVERSION, in both
of the cases you changed.

-- What do people discuss?

In my email archive of the freebsd-ports list back to 2013, I looked at all the
threads mentioning PORTVERSION or DISTVERSION in the subject, and found only
mentions of using PORTVERSION or of solving a problem by using DISTVERSION.

So, why should a port use DISTVERSION instead of PORTVERSION?

-- 
You are receiving this mail because:
You are on the CC list for the bug.