From nobody Sun Oct 06 00:13:57 2024 X-Original-To: python@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XLjSP5gYyz5XvYg for ; Sun, 06 Oct 2024 00:13:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XLjSP3Bbqz4sL6 for ; Sun, 6 Oct 2024 00:13:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728173637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fBxQyRKesHde44xzdua4QwwIKzRR+fnYfWvZDsaHBeA=; b=xG0cjtBkuRwSyh4klYDlMZN0ght6YnK6jQSes5NEjRmL3X+TrJzU5AeR/KrUjYAkU1x3of jMgM17Vsn9fF49bhO3thHHIj7n04pFqN7+z4jichNETrxQcEJvQu6jsZ3DJLV2GP/TC0sr KTcJsgZyK+Cz7HUKGUxpWE8HYuDvn6ThxOak2l2Wk+CbNpB0y08KOyVBoIbBMmOLEPey3l 2fRZ16n535UymWFrSbHnfzttMh7tX9BnqcE9rYh9ULzgQ7EKgo12gEhjIFbsd9bXVEnGuy 28HPBti/MaeuANfCSikr7eLY2qwG+KYluVk5BXl6I/brZypJpOz+QPtyQ3AMaw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1728173637; a=rsa-sha256; cv=none; b=H+4SyLwqvc0dyWfnNQxTEfIfN6YKIQibZ7MbOMw0VF92zKp+7e3cScqwOxS9UUj6407cNC +PysB6AY6r8+8pbbsrmAObT6RYXTLDg4uInSu3UiSX78VGgmZ7WnZsSMKHA/NpLTtmnW8h 06qCzUUiFiyis7vpLjj4VOpBgCiXhB2oHZPj80Vcdddn55Yc4pR1p7AgnFFZAWhbP1jsA6 UMvG1H+BHP+SXWUmfoFkQPJHf46r72sgk+CmwP64qjRoBVF3g+45nTiQkepGYHmAZEgy67 dXEs6shCMYG+PYA7AZ/DPLRPS+P3G8LEkdCNcyImvUQp0TFTp00ovQiMUGee9Q== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XLjSP2pS2zfvZ for ; Sun, 6 Oct 2024 00:13:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4960DvDS022041 for ; Sun, 6 Oct 2024 00:13:57 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4960DvO2022040 for python@FreeBSD.org; Sun, 6 Oct 2024 00:13:57 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 281847] devel/py-Automat: Update to 24.8.1 Date: Sun, 06 Oct 2024 00:13:57 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: john@saltant.com X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: vvd@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: FreeBSD-specific Python issues List-Archive: https://lists.freebsd.org/archives/freebsd-python List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-python@freebsd.org Sender: owner-freebsd-python@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D281847 --- Comment #4 from John W. O'Brien --- (In reply to Vladimir Druzenko from comment #1) Thank you for taking this PR and committing the patch. As for PORTVERSION vs. DISTVERSION, I don't understand why you changed this= . I didn't choose arbitrarily. I tried to interpret applicable information. -- What does bsd.port.mk say? ... # PORTVERSION - Version of software. Mandatory when no DISTVERSION is gi= ven. ... # DISTVERSION - Vendor version of the distribution. # Default: ${PORTVERSION} ... While this is ambiguous, b.p.m lists PORTVERSION second overall, just after PORTNAME, and DISTVERSION defaults to PORTVERSION while there is no stated default for PORTVERSION. Both of these imply that PORTVERSION is the primary designation, and that there may be a minority of cases in which DISTVERSION needs to be overridden or used instead of PORTVERSION. I cannot recall a ca= se with any port I have ever touched when setting PORTVERSION resulted in an undesired outcome. -- What do people actually use? % find /usr/ports/ -depth 3 -name Makefile \ | xargs grep -Eoh "^(PORT|DIST)VERSION=3D" \ | sort \ | uniq -c \ | sort -rn 22486 PORTVERSION=3D 9024 DISTVERSION=3D % find /usr/ports/ -depth 3 -name Makefile \ | xargs grep -Eh "^DISTNAME=3D" \ | grep -Eo "(PORT|DIST)VERSION" \ | sort \ | uniq -c \ | sort -rn 2488 PORTVERSION 1122 DISTVERSION The use of PORTVERSION is more than twice as frequent than DISTVERSION, in = both of the cases you changed. -- What do people discuss? In my email archive of the freebsd-ports list back to 2013, I looked at all= the threads mentioning PORTVERSION or DISTVERSION in the subject, and found only mentions of using PORTVERSION or of solving a problem by using DISTVERSION. So, why should a port use DISTVERSION instead of PORTVERSION? --=20 You are receiving this mail because: You are on the CC list for the bug.=