ports-mgmt/pkg: condition for a devnullfd that can be closed

Reply: Dag-Erling_Smørgrav : "Re: ports-mgmt/pkg: condition for a devnullfd that can be closed"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Tatsuki Makino <tatsuki_makino_at_hotmail.com>
Date: Mon, 16 Sep 2024 11:13:24 UTC

Hello.

While looking at libpkg/pkg_config.c, I noticed that the condition of the conditional branch in function pkg_close_devnull may not be correct.
It will not be able to close descriptor only when fd becomes 1.
I don't think it will ever be assigned 1, but I'm a little concerned about it :)

Regards.