From nobody Mon Sep 16 11:13:24 2024 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X6j304Mq6z5XB6n for ; Mon, 16 Sep 2024 11:13:48 +0000 (UTC) (envelope-from tatsuki_makino@hotmail.com) Received: from HK2PR02CU002.outbound.protection.outlook.com (mail-eastasiaazolkn190100000.outbound.protection.outlook.com [IPv6:2a01:111:f403:d401::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X6j2z1ty2z4rZF for ; Mon, 16 Sep 2024 11:13:47 +0000 (UTC) (envelope-from tatsuki_makino@hotmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hotmail.com header.s=selector1 header.b=MMl0LaHe; dmarc=pass (policy=none) header.from=hotmail.com; spf=pass (mx1.freebsd.org: domain of tatsuki_makino@hotmail.com designates 2a01:111:f403:d401:: as permitted sender) smtp.mailfrom=tatsuki_makino@hotmail.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=S0x7zfOAtekgYCC0+FGZ+oewnduqHhUJ9+Lds1xOMxjj8uHBaa+Kq8j22zyHbMdjHyr2BT1QWPbYujAu7XoVcY2Yu6NDT+c9GgLsvNZLE1luQlFuKT7j2NDqUobkbf56ugdtTe7NBpfPW+J0fqTQoCUvicDfn+fkDQDfSqNgF6pl+mzOORJQIxScdL1vGgQ6uZkfNa19F0OnPPeHMMoUpAzFVRnpvo3BG/4XYQkPlwb3ekXgkvPpWT6xK7746aRnrQMQLyYdYKhr9w1n00alkBIfJK/htrYlq6jXt/aN1qzvxrML5WpLYUGt2kVYTQBbezawrWGqwq3HTxzu6ybWtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KhjXUSMU88nvjISwjl0qbE8Cqi4jEW4aIzMvCdKvPOA=; b=qJMBiBgPlt6jxDKMOySBcUkje+nb1wt5VVrrWnk8JO3N9XNrOWRHuDAU4x9fAIQsb9IfBOLfxjuuiZtmXK3luT7CgdU18lR7lYWbHtjbwUbmwCSYTKMxhwsgfdhvyjXtGy8oy3Dw8yZMmZ1Ow9h3OxMu8m2+WXSUe3628jV56jcUztigE9mvwtHgsE5GovwFVSwNX/oQ/Vv1JkNKWn5C0jxP+eKp5bZRGWmILKDiyGlosA0uI/mB7/sBbz/xoawMHWPeUK3V/6a0To4SqjxCoR6Rb28BNSNCmETehxNgzZ3XMzlAOUEYo9A/bI9X0vQl6+nuASuurCHJiwx+z2fH4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KhjXUSMU88nvjISwjl0qbE8Cqi4jEW4aIzMvCdKvPOA=; b=MMl0LaHe428KZdKsj4gu8VPZsyrMTuvXlFrRMf32mz0XvCs1HO6KbuniA/iiUYmxmpT6EIYh8D3QAr1+6vzKJyuZFyHBDqVwapWJqlLktADvvygoZ94YiyxNgV65982QWD2gRzjNnbTT8VliW+E0haAOIILKgIy0sm40P1epXD82V/5dFOQ000NV+OVCXI8rW8vG/1cILbOGn07hn+FH+F636Lwx9U/5MHZHYWsW9Lhznb8VuPybU3reWE2G7FWTcFMKU5ebdNpZhMWfci6yEYGB7fTG3aaz0whx0eTwHLUMN2Mmtd/qouQ0oIwlUGZ+jCkmUlJLBSNKTMaoB4sAQg== Received: from SI2PR01MB5036.apcprd01.prod.exchangelabs.com (2603:1096:4:1f8::9) by SI2PR01MB4395.apcprd01.prod.exchangelabs.com (2603:1096:4:1b2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.23; Mon, 16 Sep 2024 11:13:35 +0000 Received: from SI2PR01MB5036.apcprd01.prod.exchangelabs.com ([fe80::546c:7ecf:524e:4c34]) by SI2PR01MB5036.apcprd01.prod.exchangelabs.com ([fe80::546c:7ecf:524e:4c34%5]) with mapi id 15.20.7962.022; Mon, 16 Sep 2024 11:13:34 +0000 Subject: ports-mgmt/pkg: condition for a devnullfd that can be closed From: Tatsuki Makino To: "freebsd-ports@FreeBSD.org" Message-ID: Date: Mon, 16 Sep 2024 20:13:24 +0900 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: OS0P286CA0148.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:16a::8) To SI2PR01MB5036.apcprd01.prod.exchangelabs.com (2603:1096:4:1f8::9) X-Microsoft-Original-Message-ID: <1063d2c5-4693-b6d4-fefa-a09bc01aabdc@hotmail.com> List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports@freebsd.org Sender: owner-freebsd-ports@FreeBSD.org MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SI2PR01MB5036:EE_|SI2PR01MB4395:EE_ X-MS-Office365-Filtering-Correlation-Id: 84a86361-6df2-4e1b-a394-08dcd6409ae3 X-Microsoft-Antispam: BCL:0;ARA:14566002|15080799006|19110799003|7092599003|461199028|5072599009|8060799006|6090799003|3412199025|440099028|1710799026; X-Microsoft-Antispam-Message-Info: mVzA4rbQQLkj1Sa8QHkGw+VP3qoyLH0FAIhStIm10dMH+ZuCBMPN3VfohyOuz/UqLcBB6V8JlThqQ/dmmSTFy2UiRiFbl6E20XcogIy9/8ZY2LkSZVSDNvJvkeoaExAOe+L2ZxNmPrYN6MsfxbD8Y1KgrW3F+6/Cun0UzkFfuojhK567TMz//v5ugvSwGwoQUkBQztR0BySVQHI2wv5Ft+SIZw3YMYsXPZ4CCd/qBjdDFBF5bOceZXF69uf+1LZ9czGWgg/fadfYW4z5vjvbWimmKhpWMJdWXa1jJip0Y/EzgS+m1C54wa4LsAu8QZ/92YajE97i38XKVNbxdxyIc3ovRR+c5n/OexO/35TmhG7PMIfPTTOCxrITB0ndTJFgUne8/2jtMaLLpdpJzLs1jcyP5SHhQBt6s8H0S4ikqcqNaX4cYGRyvDYDz3aKDS9HYmUaz9+21sb5jfPDc4uJRNUMoRGyFX7p7Fw80jqq/Y4hAZFqZ1hKYGTwhyYN/bwl1saWzdcvRKmjRZSojz8BF/lSSrEvSTMOs9cncQ1rnLjFGKyoLQGGBWwMGk9bh1JfH0ig7gnWoOti+5osKaXzSFMAZmNsl7BEWblzaO/Sl4lj0VgRfnlHmUR2GsvAFjlgXXUHCgpO/MTr69/bfA1h1PRetH8kD3mGCU1rvfJgvtNPM9PCnhlbvRMbFDbSY/v1nPNdaMRpp/atR3WGrRAXC9oPETAInBvPlHMWfKVkJLejP4T4gmzzr/5E0as39kUFoXGfzPx9M7HhzoXAshwW6X9iNpWQthNBK0vlqbtejCw= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFpPN1JVWEZWNUJCS0t6Q2wwNGFxdEtBaVgreFFMT3FFcWpiY2dWdDR1d1hW?= =?utf-8?B?R0VweEJBUFJWU1IxUkd5R05qU3ZDQlZmdE4zbkdmR2doTzRVdGlyaVljUUts?= =?utf-8?B?UkxHeUk1SjIzV2xZSUhBMnpYazF6bXpPaE80Q25NbG5vckNmeWhPRGVpTkYy?= =?utf-8?B?dFE0bHRVOU5PM3JIY1loWFdMazZWczJESTg4aGlKd29XNkZ0Q3lNTzIwdjg1?= =?utf-8?B?T1BtWmg3bXNyYUdnbzUrbFJHRmp1WXVxenFmS1hsOTNxYlVYUXVIdGRKaU55?= =?utf-8?B?OGh1MndCOG5FN09xOU93K3VRcjNmL0VPQTFTcHNnN3NmVWFLTHQ1VC9YUExn?= =?utf-8?B?MjFPR25RcmQxYVRZUGRqUStSMzhOdVh6VkJaM0VVaGtLY3FQRFQ5b0RMT2NT?= =?utf-8?B?a2wrN082Nm80cGtJYnNFNEg3MnhLUXYyT0VENHY4NnIrK2UwbCsxbnBvb3Jp?= =?utf-8?B?SGdRTU9iTU1VeDBiN0ZIc1E4bjJ0alpNMHd4dHRyZDFVVDRQSkZlWlFEdEh1?= =?utf-8?B?RGlsUWdQRGFpRnNZbW5ZbGVHc2RBdHFuUk9CRkMxdmxMcU1CYUIvRUVYY1B6?= =?utf-8?B?cDhLdUNudEZnV29JQTZCQ3Vnd0ZyV0JzTEl1emJhWjVjblVna0svMHZXdHVT?= =?utf-8?B?VW5KS3pjdjd2UGI2c3pUZUYzVCs5RHZwemxteVRhNCt5ZlBxai9zUFhpdUNP?= =?utf-8?B?dXlBeVZJOXU0eDZIVjVTUHVEVWdva3h4eG4waTZkRlBTcEJsQjdIWWwzaXRE?= =?utf-8?B?WGo3cTJMekozWGFQT3pLaEZZQVloM2l6S3BjNEJTdmxhYUdEOW9VWkR2anY4?= =?utf-8?B?SUNITEwrOGROeG5BbllXMUhRd0pLenJSeDlGWmhKS3g4dXZvODZIWm84U1lR?= =?utf-8?B?SWZuWkYyT1E3SE1TVWZDOHB2OG1oYXZTcGtOVUgwVy82bXVhazdYU2Npbm13?= =?utf-8?B?dEpsSGt4Z0lFNDBWQ2ZOeGg1T3FkYXBOUzVYcmZVeDdESnlYWVFLejk1R0tE?= =?utf-8?B?TnVkNEdxVVpWeEJOYStNUGtJZDh1c0cvMm04cFN0TVBoK0pyb2xqNGkxYUIz?= =?utf-8?B?QUU3QU1UMlh1bzhRVytwYTdqL2VTRW9iMWNHSk5EV0lrQWZaVzhpdXpiWXJR?= =?utf-8?B?L0lubG90QjFSU2h1N2Y2UEFZa0ljb24zd1lrbmFJclBSV1NKSndCL3lFcjUr?= =?utf-8?B?V1RhcW5LSGpQMzB1RHNtWFpGTCs2bW9ZZW5IMGM2U3owV2lvZG5sTnJ2Zk9E?= =?utf-8?B?Z3ZVYVlIWEpzdzJKK08rVkFIblptU2E0WnFSZjRYa1R2NWYwZWR5OUxYS0V6?= =?utf-8?B?WHFvK1FydUJWeXJiWmJBZWxGUHZlbDFSWlRYclhESW1LdWxHTE82M0xUSzls?= =?utf-8?B?SE9SSWlUdXJyRVo5QmROdmY4LyswTFpvSTBkMDFmOUg5V0VjQWRKZVMvNHRB?= =?utf-8?B?V2g3WEZoWVFrYVdzaHZpQmt4QmYrYkhQdlNRc3VjRFJyNSsyRTBPMU5EUjEy?= =?utf-8?B?cXdnaVBjeFpCY2NSbWdWdGpVZU9udXpnWHpSQ3l0Nm1MWStvS2Iyc1ZvRG12?= =?utf-8?B?ZkZvb2tJZC9mbWQzMzhpWFkvY21GUVY1ODNqY3MyM1VrSU9BYlhmMTJGNVVl?= =?utf-8?B?THl1MVQxMmxualExLzVxOURFd3dkSmJ4RWRCMjhZNkd2YVFCNzBFMTh0NCtY?= =?utf-8?Q?IwHILfLQ4IQmTi5GExGO?= X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-b4c57.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 84a86361-6df2-4e1b-a394-08dcd6409ae3 X-MS-Exchange-CrossTenant-AuthSource: SI2PR01MB5036.apcprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2024 11:13:34.8716 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR01MB4395 X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.50 / 15.00]; FORGED_MUA_SEAMONKEY_MSGID_UNKNOWN(2.50)[]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector10001:i=1]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[hotmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2a01:111:f403:c000::/51]; R_DKIM_ALLOW(-0.20)[hotmail.com:s=selector1]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_ENVFROM(0.00)[hotmail.com]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:8075, ipnet:2a01:111:f000::/36, country:US]; FREEMAIL_FROM(0.00)[hotmail.com]; MLMMJ_DEST(0.00)[freebsd-ports@freebsd.org]; DWL_DNSWL_NONE(0.00)[hotmail.com:dkim]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a01:111:f403:d401:::from]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_EQ_ADDR_ALL(0.00)[]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[hotmail.com:+] X-Rspamd-Queue-Id: 4X6j2z1ty2z4rZF Hello. While looking at libpkg/pkg_config.c, I noticed that the condition of the conditional branch in function pkg_close_devnull may not be correct. It will not be able to close descriptor only when fd becomes 1. I don't think it will ever be assigned 1, but I'm a little concerned about it :) Regards.