Re: Multiple new R ports

Hello,

I did take a look at review and noticed that TEST_DEPENDS are not used
and that could means that test target works without any depends or
ports are not tested at all.
My curiosity is what do you think about the importance (or not) to
have testunit feature working on R ports?

I maintain a couple R ports and testunit revealed some errors that
upstream fixed.
Maybe this testunit subject could be apply to all ports that have that feature.

Thanks,

Einar Bjarni Halldórsson <einar@isnic.is> escreveu (quinta, 22/02/2024
à(s) 08:40):
>
> Hi,
>
> Could a committer take a look at https://reviews.freebsd.org/D43735 for me?
> Adds 3 R modules, with dependencies, 13 new ports in total.
>
> Builds in poudriere and used in production.
>
> einar
>
> On 2/4/24 13:34, Einar Bjarni Halldórsson wrote:
> >> On 3 Feb 2024, at 18:56, Gleb Popov <arrowd@freebsd.org> wrote:
> >>
> >> On Sat, Feb 3, 2024 at 6:31 PM Einar Bjarni Halldórsson <einar@isnic.is> wrote:
> >>> Hi,
> >>>
> >>> I needed to create three new R ports, but with new ports for missing dependencies, it’s 13 new ports in total, all R packages.
> >>>
> >>> Should I create one PR for them all, or one for each package with blockers for dependencies?
> >>>
> >>> einar
> >> Single PR should be fine. You may also consider creating a
> >> Differential revision on our Phabricator.
> >>
> > Thanks. I created a revision in Phabricator for all the ports. We’ll see how it goes. If needed, I can chop it up into multiple revisions.
> >
> > .einar
> >
>
>


-- 
Nuno Teixeira
FreeBSD Committer (ports)