From nobody Thu Feb 22 11:43:53 2024 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TgWWT23PFz5CSs8 for ; Thu, 22 Feb 2024 11:44:05 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TgWWS6hYxz4vV3; Thu, 22 Feb 2024 11:44:04 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708602244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OxmmOCTvFdquR2yi0zoWyiDZ6BEyqvbIKqkK8taMep4=; b=n7kD/d4OiSId5Fn3uqNn1Igfeu8B4EG8I6dH0VJmo+A2EyaJ98pBxAO7/2wJlHlROVmdHl tP1mDT1FmVo4ffW1T8nqR2mvqFT/7IJVJ8Bk0XZwXXI6KI+rbGQysa9w476+VMRLNygLjP 5PAJVHKYolMsHquAdJ1ScnjoSp7HHbzHiWk0198rfNEeXvz0/F5ivUFTWyP9e++Kw4DDwU QzhXtxmhFFrRlp/zvU/6U62E5ko0m9dUw7vn7Hat8QI/5qVFveqdi80q33O4fuZUIGj6IS MUgdVa06QmdZJqoP+SWteWODVK+iFEHn+pgMJ94armwNXbP5hq3lZAenJWmaIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708602244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OxmmOCTvFdquR2yi0zoWyiDZ6BEyqvbIKqkK8taMep4=; b=pxwbfrR0bz39BCFhouJw3oyDpdIZo5DLLXZ9/eyfWe6Zh+1zsTRck05xbcYHp+edUWgU3Z HEZ/LUizvsAKC/xaEsOPoSyxqi8GRrx+ci+F2A94z0u4cdSi02MMlKaBsMRHUAHi+54FiD COaTy7UqWJ4AWxJuid0gDLHjHgR2C0hs1OVR0tthb88V0Sy2noGDq8L6OVr4blLCcGkOBJ UfRlg12zUEitlIT3TbH24i2zfpWmRVewaZBJOhyjt0GqOTRLaqUXniqEFl5A4XhVmBfSj6 jSUPx4P1E2PsToNpIxqNRk/NJR+JUr4icuhvKqnbzkOCx97s/eX45pFWvAmyBw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708602244; a=rsa-sha256; cv=none; b=sk1UfCLTD7ugzBFH7MnPnXLHH11IH2ubf3eZ2lq+MbFrqst79RbxwVAge+cnOBHyjgFamA bEJfR9ELodAWzmPeXiTqVdShGoJc4p2KY/fNm16R0+6I+W+FOiEzOEc2lFsXuOSzQ591Ik 95SfE7FPMypAeyXgBZJYTIGgKR25Bpd+/a+WriEqcdeLDU20T2ceUS03M8q9rAF+FERdo7 ppWfkHBJNSgHdf0ato4/4GgDFO2Kf4/6XUBprMwaWR6TaHFtHx02ri2bBE0wNNrr3X2rcJ kAcfipJ+f/u/B6BlWDtZ7PJKVyp192O7xbRvzT3xKIZWgpDbv7UURTvfI/u3Pg== Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TgWWS5f6Dz1NxT; Thu, 22 Feb 2024 11:44:04 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-429de32dad9so47447231cf.2; Thu, 22 Feb 2024 03:44:04 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCX7erEyRenwEOhWnx0DH99VpjwFjezfEXCJNS+/2KToPe0K4LapN3zcxYjpfLZ5waeQyRNh759FC6qtvJaEwE4NtA== X-Gm-Message-State: AOJu0YzJrGibL4jEshvm8BmFs0cGhL6hE4yeMzAUXO/2urZoQ4IXOWBr t07prY2oKmsE1BxpVSBGIGdm7DBpxuPGKqgtZFHPk4TweVzu65s5lQiFrWWv0WX+InsZL4h34aR 3HIuPbPGjZmCdUch6gFMkHwfBnTg= X-Google-Smtp-Source: AGHT+IGxzws1kaLH3p+xPyfdUZKDLMkEhZym7xMjshClAw8DUzdf0+cvDlaciMA2xIGvSadl4SJvEr0p5MEysB1imlw= X-Received: by 2002:a05:622a:514:b0:42d:a750:bd with SMTP id l20-20020a05622a051400b0042da75000bdmr23252957qtx.54.1708602244443; Thu, 22 Feb 2024 03:44:04 -0800 (PST) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 References: <44F61FC1-532F-447F-80E9-83ED37599CD7@isnic.is> <16c2bf5c-9022-4ce9-9283-838f99d80ba3@isnic.is> In-Reply-To: <16c2bf5c-9022-4ce9-9283-838f99d80ba3@isnic.is> From: Nuno Teixeira Date: Thu, 22 Feb 2024 11:43:53 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Multiple new R ports To: =?UTF-8?Q?Einar_Bjarni_Halld=C3=B3rsson?= Cc: Gleb Popov , ports@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, I did take a look at review and noticed that TEST_DEPENDS are not used and that could means that test target works without any depends or ports are not tested at all. My curiosity is what do you think about the importance (or not) to have testunit feature working on R ports? I maintain a couple R ports and testunit revealed some errors that upstream fixed. Maybe this testunit subject could be apply to all ports that have that feat= ure. Thanks, Einar Bjarni Halld=C3=B3rsson escreveu (quinta, 22/02/2024 =C3=A0(s) 08:40): > > Hi, > > Could a committer take a look at https://reviews.freebsd.org/D43735 for m= e? > Adds 3 R modules, with dependencies, 13 new ports in total. > > Builds in poudriere and used in production. > > einar > > On 2/4/24 13:34, Einar Bjarni Halld=C3=B3rsson wrote: > >> On 3 Feb 2024, at 18:56, Gleb Popov wrote: > >> > >> On Sat, Feb 3, 2024 at 6:31=E2=80=AFPM Einar Bjarni Halld=C3=B3rsson <= einar@isnic.is> wrote: > >>> Hi, > >>> > >>> I needed to create three new R ports, but with new ports for missing = dependencies, it=E2=80=99s 13 new ports in total, all R packages. > >>> > >>> Should I create one PR for them all, or one for each package with blo= ckers for dependencies? > >>> > >>> einar > >> Single PR should be fine. You may also consider creating a > >> Differential revision on our Phabricator. > >> > > Thanks. I created a revision in Phabricator for all the ports. We=E2=80= =99ll see how it goes. If needed, I can chop it up into multiple revisions. > > > > .einar > > > > --=20 Nuno Teixeira FreeBSD Committer (ports)