[Bug 281800] news/nzbget: Update to 24.3

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281800

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz@FreeBSD.org

--- Comment #2 from Robert Clausecker <fuz@FreeBSD.org> ---
maintainer timeout

Here is some feedback on your patch:

 - we ship zlib in base, no need to make depending on it optional
 - if you make a dependency optional, make sure we don't actually depend on it
   when the option is turned off.  This e.g. affects ncurses, on which this
   port unconditionally depends through USES=ncurses even when the option is
   turned off.  Fix this by adding ncurses to NCURSES_USES instead of USES.
 - instead of a hand-rolled do-test target, set USES= cmake:testing.  This will
   add the right code to hook up cmake test suites.
 - I don't see you adding openssl or gnutls to the dependencies anywhere.  Make
   sure dependencies are added when the corresponding options are enabled.
 - TLS cannot be enabled as it's an option group.

Please test the patch carefully with Poudriere before submitting it.  Test all
port options to make sure the dependencies are configured correctly.  Many of
these issues would have been caught quickly with proper testing.

Please fix your patch and resubmit.

-- 
You are receiving this mail because:
You are the assignee for the bug.