From nobody Sat Oct 26 14:01:32 2024 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XbLt51vNjz5ZmXc for ; Sat, 26 Oct 2024 14:01:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XbLt45C8tz4PM6 for ; Sat, 26 Oct 2024 14:01:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729951292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F3NAUE0hqRovHYr9ORPbQiabIGter5hdJG5YkIrGndw=; b=aKnp8P8BLUEdkoqtn+neQPFCJaU2XQYbAiZYpidMk2BwMIyN6yuEO3NmUJC6EAB+os9up5 xCa7mmNgWeOffDe30TXmhqQhxvBcRkL3LTN4ZuTOKuw8sBQxKl1kP4jduwhSXKZEJJ0nW8 2ek5Ri94c29gDmNexRXokTKtioFDn6VYSUHGmylAC2dnyRo1+W6IuvyiscPh09WTTFG6Cg MeJIieHAiY9KO+zB1TVx7iO3Qi4VMJ3EUfAZeMwmEu8A9VIsCXsZF1wuj18SZfcnC79hYH 6AQOau/Oc6JgMHZwpJ4baB8y3b0HCKvWi0E3IvccCupv2/XbIYWQnn3W4XJ0gQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729951292; a=rsa-sha256; cv=none; b=uXYQf0OpEEHWe6dSrtveP44iWKi0R/cpyIVONhk8R/+/pqLQje/lal15ijtrioOGMYzZW+ 1Hq/9y78WClXDmnSkGD7I6OXrpK5jfFY2/rc5AbEv3ZSvduV4Yq6l0lCt/ECO56yCR82mF EERzvNnMtEwrn4sg2sv/1OLo0E8Q7+Yl8Sz4xhvElrEyCLTfufP8wm3VQhkwmK8ad+6QLq Sbd+0ja1OHierhbARumIDTQnoep6ZRgTWzeGsdyO+YvtHrhu6jKk8C5IO4q9FJwpbntBiy zO2hT8LDlyXT6Y/HgQ0l6uGcHizH+e8l2jJyIeGNPmG/7oY9E7ZCswReziX+Mw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XbLt44pZWz1CMd for ; Sat, 26 Oct 2024 14:01:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 49QE1WCM082285 for ; Sat, 26 Oct 2024 14:01:32 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 49QE1WCT082284 for ports-bugs@FreeBSD.org; Sat, 26 Oct 2024 14:01:32 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 281800] news/nzbget: Update to 24.3 Date: Sat, 26 Oct 2024 14:01:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: fuz@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports-bugs@freebsd.org Sender: owner-freebsd-ports-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D281800 Robert Clausecker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fuz@FreeBSD.org --- Comment #2 from Robert Clausecker --- maintainer timeout Here is some feedback on your patch: - we ship zlib in base, no need to make depending on it optional - if you make a dependency optional, make sure we don't actually depend on= it when the option is turned off. This e.g. affects ncurses, on which this port unconditionally depends through USES=3Dncurses even when the option= is turned off. Fix this by adding ncurses to NCURSES_USES instead of USES. - instead of a hand-rolled do-test target, set USES=3D cmake:testing. Thi= s will add the right code to hook up cmake test suites. - I don't see you adding openssl or gnutls to the dependencies anywhere. = Make sure dependencies are added when the corresponding options are enabled. - TLS cannot be enabled as it's an option group. Please test the patch carefully with Poudriere before submitting it. Test = all port options to make sure the dependencies are configured correctly. Many = of these issues would have been caught quickly with proper testing. Please fix your patch and resubmit. --=20 You are receiving this mail because: You are the assignee for the bug.=