[Bug 280134] lang/php83: rename rc script to comply to the rc scripting recommendations

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 05 Jul 2024 07:54:58 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280134

            Bug ID: 280134
           Summary: lang/php83: rename rc script to comply to the rc
                    scripting recommendations
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: bofh@freebsd.org
          Reporter: netchild@FreeBSD.org
             Flags: maintainer-feedback?(bofh@freebsd.org)
          Assignee: bofh@freebsd.org

Created attachment 251877
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=251877&action=edit
fbring rc script in-line with the rest of the ports collection

Hi,

The attached patch fixes some issues with the rc script.

A generic discussion about the rc scripts in the ports collection which
contains a lot more background information about the "why" of this patch is at 
    https://lists.freebsd.org/archives/freebsd-ports/2024-July/006342.html

Short:
 - the filename shall be the same as the content of the name variable inside
the script
 - PROVIDE shall be the same as the content of the name variable inside the
script
 - this fixes the use of the script with service jails

Additionally to what is discussed there and fixed in the patch, I made the
following additional changes:
 - fix the variable names in the comments to comply to the reality inside the
script
 - lang/php82: contains also the service jails options variable you have
already committed to lang/php8[13] (simply because I have it in my poudriere
tree I generated this patch from)
 - add an UPATING entry (date needs to be adapted)

You may want to run the following before applying the patch:
  git mv lang/php81/files/php-fpm.in lang/php81/files/php_fpm.in
  git mv lang/php82/files/php-fpm.in lang/php82/files/php_fpm.in
  git mv lang/php83/files/php-fpm.in lang/php83/files/php_fpm.in

This is tested with lang/php83 in multiple places with service jails.

Bye,
Alexander.

-- 
You are receiving this mail because:
You are the assignee for the bug.