From nobody Fri Jul 05 07:54:58 2024 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WFm5H3JxKz5QnTM for ; Fri, 05 Jul 2024 07:54:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WFm5H1ytVz4cgQ for ; Fri, 5 Jul 2024 07:54:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1720166099; a=rsa-sha256; cv=none; b=g67EltAqoWrUnCGZOFS1ar68fLbWcBwfzRGk/Mskm2KrLcj8RT71zKddzgf6WZB92pDRGM W38CYph6AX2/qEd6cVNWITBS7gP9fx5jCePGc6TI5seuzF0uQsymtNZWrd1bBU5RdqHZZx NmArevtTZ4ePxd0oFoPwmNk8jJWPn/yb1f2QJSZdh43LIwPL+WeoUihfpG60A+38g0TXJk cOjwLSAzvnbqVzlSKDVNX8BcBqMbGwjN1Xvy+QUsOX4tJwLzUw0nlngWng8E6EzaGkQjAC jYIPUgdgEENdIEwPH/87dOp20R9Bbdl4DCR6nYnwPjctdVM/7gx3lzhzUxzRCA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1720166099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OKU7uaoPcqlWt0xwXHIxAn9LeyqwCi6JpqazPfuhSvo=; b=xKS88E4GOs8L54W/0OvjyGUbSUQhiU8+IsP/UUwEP8SQyG/15gc0oPWf3DYIFFohGw/P+8 nd43JfNc5IpR+osfYOq2jb5qOjPbOuiBNScbgpI5K/zRKllGLKYRyoNpoupZUlSigcJRi2 Y2gTWpUIHEL2k/gGK8ojFB+0aDtwfDO/Nb2Eb+QxlefzI/W+HMGxab5SvpBEDDdHKQEPRw WgFQK1N9t2qVe6Lx4aCTzA7Hae0WmtrHdzZOEKFjsSJvlD2i8OW6CiOe/mALOYpYHIzQn8 I22aaL0jA+2DrrwWyp7rlRwUI9PmNi8lO5PCrbc1CYuGAQV6NPogu9fvwjiiow== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WFm5H1TLjzpQL for ; Fri, 5 Jul 2024 07:54:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4657sxYu070034 for ; Fri, 5 Jul 2024 07:54:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4657sxGf070029 for ports-bugs@FreeBSD.org; Fri, 5 Jul 2024 07:54:59 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 280134] lang/php83: rename rc script to comply to the rc scripting recommendations Date: Fri, 05 Jul 2024 07:54:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: netchild@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bofh@freebsd.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports-bugs@freebsd.org Sender: owner-freebsd-ports-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280134 Bug ID: 280134 Summary: lang/php83: rename rc script to comply to the rc scripting recommendations Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: bofh@freebsd.org Reporter: netchild@FreeBSD.org Flags: maintainer-feedback?(bofh@freebsd.org) Assignee: bofh@freebsd.org Created attachment 251877 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D251877&action= =3Dedit fbring rc script in-line with the rest of the ports collection Hi, The attached patch fixes some issues with the rc script. A generic discussion about the rc scripts in the ports collection which contains a lot more background information about the "why" of this patch is= at=20 https://lists.freebsd.org/archives/freebsd-ports/2024-July/006342.html Short: - the filename shall be the same as the content of the name variable inside the script - PROVIDE shall be the same as the content of the name variable inside the script - this fixes the use of the script with service jails Additionally to what is discussed there and fixed in the patch, I made the following additional changes: - fix the variable names in the comments to comply to the reality inside t= he script - lang/php82: contains also the service jails options variable you have already committed to lang/php8[13] (simply because I have it in my poudriere tree I generated this patch from) - add an UPATING entry (date needs to be adapted) You may want to run the following before applying the patch: git mv lang/php81/files/php-fpm.in lang/php81/files/php_fpm.in git mv lang/php82/files/php-fpm.in lang/php82/files/php_fpm.in git mv lang/php83/files/php-fpm.in lang/php83/files/php_fpm.in This is tested with lang/php83 in multiple places with service jails. Bye, Alexander. --=20 You are receiving this mail because: You are the assignee for the bug.=