[Bug 274026] games/moonlight-embedded update to 2.6.0

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274026

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz@FreeBSD.org

--- Comment #1 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your contribution.

Please only submit the diff in the future.  The distfile is downloaded by the
port and the files in the ports tree can be constructed from the diff.  So
these
two other files are not required.  Also, submitting an archive makes it harder
to
review the patch as it cannot be viewed in bugzilla's UI.  Lastly, please
submit 
the diff in "git-format-patch" format if possible.

As for the patch itself, here are some items to check:

 - REINPLACE_CMD must not be used for static replacements (i.e. where the text
to 
   be changed is always the same).  Use patch files instead.  The original port
   did this wrong, please switch to patch files for this update.  You can keep
   REINPLACE_CMD for dynamic replacements, such as the one where ${PREFIX} is
   patched in.
 - I see that you have added quite a few patches.  Could you please explain
what
   they do?  Have you submitted them to upstream?  If yes, could you link the 
   pull requests / bug reports?  While some of the patches look like obvious
   portability patches, others seem like they do more complicated things.  We
   usually try to keep ports as close to upstream as possible.  It would be
   better if upstream included these patches instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.