From nobody Fri Sep 22 15:07:24 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RsbGh5PXCz4v0v3 for ; Fri, 22 Sep 2023 15:07:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RsbGh4B3tz3ZJr for ; Fri, 22 Sep 2023 15:07:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695395244; a=rsa-sha256; cv=none; b=bJW1phNoLQMrXvf/tnY3N2SMDDkJ0YvnNAmNjCpah20CGUf8gmw7ZV8FnNXuCdalRoBtmC lXlhu4aOul9oMOxaxBBD1ww8OqEUWp6ztjrIBM1Vwrmnv5th8EOoEHXkn0w8DXzBFVCCGX i4ttjeUbP5YFFrE5tW5lVJ3BqQF2RWE1n/EKaNwEAQlKJao/DFSCeu2/tzrHoPNVy+9Ne1 XG6nRzvwxnOOD8Sas2Mg0xk4fr0Ax1uNPnT1+W1JlnpHiGuMW+pSfncJqdOs6O22Wy3Shb ++7dmM/uLUtSVWkFujlShaIdrHIxU/fpNKIt7yM8hDnZEmXWKwDxAEomFMoTgw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695395244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UVceZMvRbCnx2Jag+3RlpdRUud+Lm8GLh4lUwuGPpGY=; b=uLJU+/Sc1ZXBrmOVawVqFELTUayq9bNy36aDQ5dnPn2QvIDJGpHmASNUCqbY5fi90sm0NP UiNdrpD/f5tPfX+7y9hnkaQk08w43bEKW8PRFTPye+Je2FJ7WtWLTRlFscDJn6IPpJ8/Uz NKrKQLtV2HCsNjiX+VX1n/ZZvWt2gx8KwVXh/Xhh4Xz0TGDB2Nw2bl4ShWPNJkSqnuDbAN B6+/kbWqOidTh0R1sLacDANfsoqhoCnGl7fuFdNl4lG8JLXugDyPh28lXgs6SikyBk/DIi Zq6Ql8RP7LHDBfnNAPXIs1A9X8d+VTLblBmuueKLUo/kWifkZelHg11FZ3ATKA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RsbGh30w3zBkX for ; Fri, 22 Sep 2023 15:07:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 38MF7OlT057600 for ; Fri, 22 Sep 2023 15:07:24 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 38MF7OhS057598 for ports-bugs@FreeBSD.org; Fri, 22 Sep 2023 15:07:24 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 274026] games/moonlight-embedded update to 2.6.0 Date: Fri, 22 Sep 2023 15:07:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: fuz@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274026 Robert Clausecker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fuz@FreeBSD.org --- Comment #1 from Robert Clausecker --- Thank you for your contribution. Please only submit the diff in the future. The distfile is downloaded by t= he port and the files in the ports tree can be constructed from the diff. So these two other files are not required. Also, submitting an archive makes it har= der to review the patch as it cannot be viewed in bugzilla's UI. Lastly, please submit=20 the diff in "git-format-patch" format if possible. As for the patch itself, here are some items to check: - REINPLACE_CMD must not be used for static replacements (i.e. where the t= ext to=20 be changed is always the same). Use patch files instead. The original = port did this wrong, please switch to patch files for this update. You can k= eep REINPLACE_CMD for dynamic replacements, such as the one where ${PREFIX} = is patched in. - I see that you have added quite a few patches. Could you please explain what they do? Have you submitted them to upstream? If yes, could you link t= he=20 pull requests / bug reports? While some of the patches look like obvious portability patches, others seem like they do more complicated things. = We usually try to keep ports as close to upstream as possible. It would be better if upstream included these patches instead. --=20 You are receiving this mail because: You are the assignee for the bug.=