[Bug 274953] emulators/wine-devel: Makefile maintenance & dependency cleanup

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274953

Gerald Pfeifer <gerald@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gerald@FreeBSD.org

--- Comment #2 from Gerald Pfeifer <gerald@FreeBSD.org> ---
At a first glance this looks fine. Just please, *please*, PLEASE let's
not go for all those whitespace changes.

Damjan made a series of such whitespace changes when becoming maintainer
two years ago. This now would be yet another such set of changes.

 * That makes the wine-devel and wine ports diverge for no real benefit
   (and I worked to align them again after Damjan's changes).

 * It destroys `git blame`.

 * And many of us really don't consider the PLIST_SUB change, let alone

     (cd ${WRKSRC} && \
             ${MAKE_CMD} depend)

   over

     cd ${WRKSRC} && ${MAKE_CMD} depend

   and improvement (looking at ports in general).


(Don't get me wrong, I also have been trying to stay within 80 columns;
it's just a balance.)


This port has been portlint-clean (where reasonable) for two decades.
portclippy and portfmt have their own preferences - and I recommend
against simply applying the latter.

If you want to apply changes suggested by the former, I'd do that as
a distinct commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.