From nobody Sun Nov 12 11:02:18 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SSqQM0djXz50D1y for ; Sun, 12 Nov 2023 11:02:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SSqQL5nzzz3RHY for ; Sun, 12 Nov 2023 11:02:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699786938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TtfIsBT9Jm/3JUkQDI8vFYYnRPSsGvhmAtfzzsdinHc=; b=ZiaoUIJGaZZLXtUokTm1OAFqwqv4RmCij6Abk9zy4wKrOqgxP/ySRkIqd3kyMda5FUA+ug 5fr1U3eUhspgItVjqB+6n4kDVSJnMJQgMLmEnE4gB0q1NYsptmBfIiYbxIvv7YC1m9p/FD 2whqSDEVrJ+NS1k+hXedz1vOHw26+YDUQNm20+5qlAmnT5Z99eM67lVPmO/Wb0Q/1omFXR nt1dIuKpHzXJOm0qgDHLWY34ZbUdul0JdFMsLdA2Ci9Mmhn8C8j9jQ84YO0Fb835DmATNp PLrAmLzKfyov8B34+33bXK2puZrLyisGbk/62ZjYzKzwKN1p59w5a6hIc1C7yw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699786938; a=rsa-sha256; cv=none; b=hBEXu/hwDEYC+RtSQKPSJ/8ppNcIkxsmcjCSGn9sGniiqrAwjf2FjwHtOn3dSV7EOdr2y/ xzicJEqj4MD7uqlmdRSW9E0O2XDY4Qig/Oc3lk4gYGRxqtSpInM/KR4sBjYLzD0LCZIPd2 RnsMuR03mvog3ZSbcN6q9TW/y1xqkb8KKJBYai6+fkn0ordzK7yhA7zAV1nxs/lr9TeRQA 6ochX4RO9g0BQBwKu52PkwqPifT1DFzM0rKhZTCbg2LR88thAO2pZfPymIG2+w1Mc2j3rV PXU/AXdo+o9tViUEzfC+B2ipXfyHpOPRv5r52rwuUk63ZsxEGm4SWckSbpg1Sw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SSqQL4rr0z5qx for ; Sun, 12 Nov 2023 11:02:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3ACB2IHo004472 for ; Sun, 12 Nov 2023 11:02:18 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3ACB2IRn004471 for ports-bugs@FreeBSD.org; Sun, 12 Nov 2023 11:02:18 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 274953] emulators/wine-devel: Makefile maintenance & dependency cleanup Date: Sun, 12 Nov 2023 11:02:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: gerald@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274953 Gerald Pfeifer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gerald@FreeBSD.org --- Comment #2 from Gerald Pfeifer --- At a first glance this looks fine. Just please, *please*, PLEASE let's not go for all those whitespace changes. Damjan made a series of such whitespace changes when becoming maintainer two years ago. This now would be yet another such set of changes. * That makes the wine-devel and wine ports diverge for no real benefit (and I worked to align them again after Damjan's changes). * It destroys `git blame`. * And many of us really don't consider the PLIST_SUB change, let alone (cd ${WRKSRC} && \ ${MAKE_CMD} depend) over cd ${WRKSRC} && ${MAKE_CMD} depend and improvement (looking at ports in general). (Don't get me wrong, I also have been trying to stay within 80 columns; it's just a balance.) This port has been portlint-clean (where reasonable) for two decades. portclippy and portfmt have their own preferences - and I recommend against simply applying the latter. If you want to apply changes suggested by the former, I'd do that as a distinct commit. --=20 You are receiving this mail because: You are the assignee for the bug.=