[Bug 262032] [NEW PORT] devel/xnvme: Cross-platform libraries and tools for NVMe devices

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262032

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz@FreeBSD.org
             Status|New                         |Open

--- Comment #1 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your submission.  I'm sorry it took so long to respond.  Please
check the following issues:

 - please check the indentation of the port Makefile.  You can use the portfmt
   utility to format the port automatically.
 - is NASM really needed at runtime?
 - libraries should be depended on using LIB_DEPENDS, not RUN_DEPENDS.
 - For OpenSSL, use USES=ssl to have the ports framework pick the
   right dependency.
 - For ncurses, use USES=ncureses to have the ports framework pick the right
   dependency
 - why is git needed as a build dependency?  Can it be removed?  Many projects
   try to use git to determine some sort of commit ID for the build.  This is
   broken when building from within the ports tree as the ports tree itself is
   managed using git and the script is likely to just pick up the current
commit
   of the ports tree.  If present, such scripts have to be patched to not check
   for a git commit.
 - the do-build and do-install targets are not needed.  The builtin targets
   already do the right thing.
 - please move WWW from pkg-descr to Makefile.  There has been a change in the
   way the project homepage is handled and we no longer accept ports using the
   old style.
 - please make sure to set maintainer-approval on your patches to make sure
they
   get looked at quickly.

Rest of the port looks okay.  Can probably commit once these issues are
addressed.

-- 
You are receiving this mail because:
You are the assignee for the bug.