From nobody Thu May 04 12:01:53 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QBsqk2tVyz4930t for ; Thu, 4 May 2023 12:01:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QBsqj56MRz4RtF for ; Thu, 4 May 2023 12:01:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683201713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EHzwuRBQBzhJwNyziZB4zmPyp0xX7L17hgcNssOJtQY=; b=vt2yYzJsY5eVPhPx6bUqjik2Vpem3MpMVE9pvnSOkLMh5+pOR59sCok18Q7H5ecEpq5cx7 l+9EwnbRCOzxLPc4bcv1FEkU6RWJZawkiFZd0s7vzikA9QGAFFohiL0C1t2GiKMXPdgu/e E0pQ65lGBBPK4JSkqoTnbGMfALWIG2TohWdbrTlulJlz1O5eOort6GVHCZ9hdBJKzlLtSG oWEu/Sj8uHLfX1f8DZHniq5m9z+AfNfeEuLgtRVkN6mNH0C9gmDZEipbycQ0lUFhttraPD R/l9ta8V4JaCi5ZG5vDtxmK0UoZBad+S5S44W31BEmATfhZkJxneJMzqorFxFg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683201713; a=rsa-sha256; cv=none; b=rN1EAS2rfmlpCXoijEGLKZNj7lQmTAfbcjDrhn3LeXg46MaX34l/l75YuOzBqz0iZsgAjP uxziRsgC0Qo/0aSm3CrwjFS3smf1HyNxXBo45IVuYF5+oW2olRZz9wwFkXjjscA+LAcJhY tn5aG6l+ECGAh3l8NCP/WaOHwbknf8nIQC9MzK6q0WKbv094AjSsVaJycD+DQbp4WHt1N+ NUtEVCSzacFtF98gl0Y0AdQXOym46obSETTVh12b3/W2W2xVhqM0IHV+xPCR7hknOMtoWS T5iQ5d4rI4VamgzqaQCb7b5q0SkBrewFlmfbfVWvep2kPNp5dmHE1PJ35zkAYg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QBsqj49GCz19Y6 for ; Thu, 4 May 2023 12:01:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 344C1rFP092887 for ; Thu, 4 May 2023 12:01:53 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 344C1rvl092856 for ports-bugs@FreeBSD.org; Thu, 4 May 2023 12:01:53 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 262032] [NEW PORT] devel/xnvme: Cross-platform libraries and tools for NVMe devices Date: Thu, 04 May 2023 12:01:53 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: fuz@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262032 Robert Clausecker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fuz@FreeBSD.org Status|New |Open --- Comment #1 from Robert Clausecker --- Thank you for your submission. I'm sorry it took so long to respond. Plea= se check the following issues: - please check the indentation of the port Makefile. You can use the port= fmt utility to format the port automatically. - is NASM really needed at runtime? - libraries should be depended on using LIB_DEPENDS, not RUN_DEPENDS. - For OpenSSL, use USES=3Dssl to have the ports framework pick the right dependency. - For ncurses, use USES=3Dncureses to have the ports framework pick the ri= ght dependency - why is git needed as a build dependency? Can it be removed? Many proje= cts try to use git to determine some sort of commit ID for the build. This = is broken when building from within the ports tree as the ports tree itself= is managed using git and the script is likely to just pick up the current commit of the ports tree. If present, such scripts have to be patched to not c= heck for a git commit. - the do-build and do-install targets are not needed. The builtin targets already do the right thing. - please move WWW from pkg-descr to Makefile. There has been a change in = the way the project homepage is handled and we no longer accept ports using = the old style. - please make sure to set maintainer-approval on your patches to make sure they get looked at quickly. Rest of the port looks okay. Can probably commit once these issues are addressed. --=20 You are receiving this mail because: You are the assignee for the bug.=