[Bug 254596] if_bridge wants LRO turned off, if_vlan insists it remain on

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254596

--- Comment #9 from paul vixie <paul@redbarn.org> ---
(In reply to Naman Sood from comment #7)
i've now tested this patch and it does what i need. the LRO option remains on
for the physical interface and for the vlan subinterfaces which are not added
to a bridge. i did not performance-test the physical interface or other
subinterfaces to see what impact LRO was having, but input coalescence is a
theoretical boon and i'm glad to not have to turn off LRO on the physical
interface in order to protect the bridge members from having LRO turned on
inappropriately.

the main motivation is to avoid input coalescence on the bridge member, since
the other bridge members are tap(4) interfaces each belonging to a bhyve guest
(where the interface shows up as a vtnet(4) interface.) input coalescence in
this case is not just a performance problem it damages the input flow and makes
the bhyve guest unusable. i was working around this by turning off LRO on the
physical interface but this is a price too high: bhyve guests whose bridge is
connected not by a physical interface but by a vlan subinterface must "just
work".

i am attaching a second patch, this time in "git format-patch" format, since
this was requested. it looks the same to me. can this patch be reviewed for
inclusion in 13.3 and also pulled into the 13.2 release in the next maintenance
patch?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.