From nobody Fri May 12 16:51:46 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QHvtV2S9Kz4BDp4 for ; Fri, 12 May 2023 16:51:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QHvtT73nMz4RrP for ; Fri, 12 May 2023 16:51:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683910306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xwTwNoXGIDH/mnx1ExfVgvlr1qVIyLbSITHGXUc2TVg=; b=IVCw277Mx2eGPs9Aa4H6FWQ+4EwB+UBKjhh0n6SytZL0Jg6R8GfK0KQmI9tKz8Hw+qMLMe VcL9oHGcpfm8YBSFJlpGwcx4V8sPE/8wflJ3hpZOdStQ/WpFeh3FAvt9IFAPyWoDlLt8h+ B3svRVcbJCA9MMe8p6nqRQylpSC9J+uAVscHsIx46h5LnRCj97DRR8s0VtB4R9+PO6Mmx6 tAruQqZ7F3dw58qRXyBBSdnQEJF19sX3/F+9WKji8WBIAHWZ4Jj4th0+ASidRQjNDDxB1O EWZ7Pb2cfFMt+s8K1O0VnpG0bQ0pxXj0SzcUTGwUEEMGgUSwoTuanQvTzCl4ig== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683910306; a=rsa-sha256; cv=none; b=RFr3LumX4PUQEdoqmHu7bcuamRRcaug5XPvD2K3ZJz5wKjH179DrStKWW7STjpnPC7AY5l 08rM15x4u4iBXuPZqasppaMrwg1h89xupd+1cJOAWC3np9JAUg2c0RjqA7KguPaRTYlfK3 JMZp5Z/JK/SqyuXJF7dqWJioq26o0/XcknS7lIMUntaAttqov5oFTuFIvG8+ZerdLcT4U9 Nm+ZRHuCWygKC7A/pUpBF+2UqvqYifixDjfS4Yan5ZUNCZrHto0PC6l3Yrn46f+REXgY7t TIvdPev5GVB5N3nfOjPuLaiDeNeFRZBw9jwCLbvRn+kT0lVqN3+GrlfkZbN2ew== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QHvtT6862zjc9 for ; Fri, 12 May 2023 16:51:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 34CGpjd3081672 for ; Fri, 12 May 2023 16:51:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 34CGpjn7081671 for net@FreeBSD.org; Fri, 12 May 2023 16:51:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 254596] if_bridge wants LRO turned off, if_vlan insists it remain on Date: Fri, 12 May 2023 16:51:46 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.2-RELEASE X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: paul@redbarn.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? mfc-stable13? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D254596 --- Comment #9 from paul vixie --- (In reply to Naman Sood from comment #7) i've now tested this patch and it does what i need. the LRO option remains = on for the physical interface and for the vlan subinterfaces which are not add= ed to a bridge. i did not performance-test the physical interface or other subinterfaces to see what impact LRO was having, but input coalescence is a theoretical boon and i'm glad to not have to turn off LRO on the physical interface in order to protect the bridge members from having LRO turned on inappropriately. the main motivation is to avoid input coalescence on the bridge member, sin= ce the other bridge members are tap(4) interfaces each belonging to a bhyve gu= est (where the interface shows up as a vtnet(4) interface.) input coalescence in this case is not just a performance problem it damages the input flow and m= akes the bhyve guest unusable. i was working around this by turning off LRO on t= he physical interface but this is a price too high: bhyve guests whose bridge = is connected not by a physical interface but by a vlan subinterface must "just work". i am attaching a second patch, this time in "git format-patch" format, since this was requested. it looks the same to me. can this patch be reviewed for inclusion in 13.3 and also pulled into the 13.2 release in the next mainten= ance patch? --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.=