[Bug 105943] Network stack may modify read-only mbuf chain copies

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 08 Aug 2023 19:49:03 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=105943

Ed Maste <emaste@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emaste@freebsd.org

--- Comment #6 from Ed Maste <emaste@freebsd.org> ---
Git hash for that comment: 9983b3c02def80c27bf3ca0284fba2537d932f4b

I don't think it's really a local workaround though -- if a writable mbuf is
needed, m_dup is the correct call. The "general solution" is to use m_dup when
it is necessary to do so.

m_copy was removed in:

commit c3bef61e584084a8f86fba71cb344f15fc20491c
Author: Kevin Lo <kevlo@FreeBSD.org>
Date:   Thu Sep 15 07:41:48 2016 +0000

    Remove the 4.3BSD compatible macro m_copy(), use m_copym() instead.

    Reviewed by:    gnn
    Differential Revision:  https://reviews.freebsd.org/D7878

There are 81 instances of "m_copym" in the tree still, across 41 files.

> less used L2 modules such as arcnet, fddi, and token ring still suffer from the same bug.

These are all gone.

-- 
You are receiving this mail because:
You are the assignee for the bug.