From nobody Tue Aug 08 19:49:03 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RL3fT67QFz4q1VH for ; Tue, 8 Aug 2023 19:49:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RL3fT53zkz4hDN for ; Tue, 8 Aug 2023 19:49:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691524145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/DfLotPFC1kPeDith5lmWpGnQ8VuN1sDiMArBHAAHrk=; b=fHYjvO6NwhpHlUXs08udYE5lmTf/mD4gHeCAhDVmrB27sq/Urk2WfHOXXEVcF1myzN8h8q 0hxGZMdvhJiRYutcvAYfZ/vAC96nX9WP1FxTGmZBZQyBR3oaC2wGAv4tHctsFYANSMF/Ha 8ZZoiQ0/XFmyO0QB2ca4nyX782rxyF/DWjkaiwn50v/g874yhfFRdJ4P00hc2/L3D0A33p +zPobpUrWvC9X7DxMRNcWzfanT82/gar3nX3NKW/1GgaYkpBJYsooanzXdOU2HIYIPxg1k zmO/eDC9Po2wDQVKwuaYJHqBgSvNjKb3KHWTDmKwlWjwcQCGjIiF/RGOCf8mtQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1691524145; a=rsa-sha256; cv=none; b=pbxWhlkwsiG/BsBNb0gIV5AV1eEP8GdJbKW6sDw3DFynKn/4aI0q1mCLeXNKMY4Uk167K5 Y4ctuuHR0e2q9vth6ECKOAVpQxO/2y0oBizHTS8FCyw0fI1qUG3+PDCyyAvn8vU0zWyvQi rqFTwIyJgLqSbxNey44hCbhPJP7qlFhF5G/z1++IcgRuvJVEiWgui0uyKDnOk8echNzhC1 PkQ9RAvERvGiRujBnyoBpo+jfrjmndNybjYzC35mMfC8mHDjSiH9gQvQRBCbG4zWs+crIt k4cCTCt0/fHugMbrifDPsWmaUO6F8rif2nBdRFMRERVpF8JYZ4Rr5igdJLi6zQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RL3fT41NCzml9 for ; Tue, 8 Aug 2023 19:49:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 378Jn5gg064266 for ; Tue, 8 Aug 2023 19:49:05 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 378Jn5f1064265 for net@FreeBSD.org; Tue, 8 Aug 2023 19:49:05 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 105943] Network stack may modify read-only mbuf chain copies Date: Tue, 08 Aug 2023 19:49:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 7.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: emaste@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D105943 Ed Maste changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emaste@freebsd.org --- Comment #6 from Ed Maste --- Git hash for that comment: 9983b3c02def80c27bf3ca0284fba2537d932f4b I don't think it's really a local workaround though -- if a writable mbuf is needed, m_dup is the correct call. The "general solution" is to use m_dup w= hen it is necessary to do so. m_copy was removed in: commit c3bef61e584084a8f86fba71cb344f15fc20491c Author: Kevin Lo Date: Thu Sep 15 07:41:48 2016 +0000 Remove the 4.3BSD compatible macro m_copy(), use m_copym() instead. Reviewed by: gnn Differential Revision: https://reviews.freebsd.org/D7878 There are 81 instances of "m_copym" in the tree still, across 41 files. > less used L2 modules such as arcnet, fddi, and token ring still suffer fr= om the same bug. These are all gone. --=20 You are receiving this mail because: You are the assignee for the bug.=