[Bug 280840] net-im/purple-gowhatsapp: maintainer upgrade from 1.15.0 to 1.16.0

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280840

--- Comment #10 from Vladimir Druzenko <vvd@FreeBSD.org> ---
(In reply to Mikhail T. from comment #9)
> You renamed $o into ${_db} -- a multi-letter variable must be
> surrounded by braces in make -- which worsens the æstethics considerably
Disagree. "XXX${o}XXX" much better read than "XXX$oXXX". And "æstethics" is
better too.

> Also, even though currently the only two options are, indeed,
> database-related, some day they may be of other kind -- which
> is why I'd prefer the more generic "o", for "option".
When that happens, I'll rename it to "_opt".

> The name of the multi-option is presented literally to the user --
> and my original "DB-backends" is grammatically correct, whereas
> the new "DB_BACKENDS" is a perversion :(
Name of option "DB-backends" look strange.
Anyway I added "DB_BACKENDS_DESC=       Database backends" with good
description.

> I know, you're trying to please portclippy et al, but I think,
> you're following it a little too blindly.
No. I trying make port better. portclippy is just tool with recommendations.

The port needs to be written in such a way that other developers don't waste
time trying to figure out the intricacies that another developer has created.
Large open source and commercial projects are not the place to show off your
programming acrobatics. This should be done in personal, academic projects or
programming contests.

So if you have no other arguments, I insist on the proposed changes, aimed at
improving the understanding of the port by other developers.

-- 
You are receiving this mail because:
You are on the CC list for the bug.