From nobody Tue Sep 03 22:13:19 2024 X-Original-To: go@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wz0J11WGYz5MX4c for ; Tue, 03 Sep 2024 22:13:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wz0J06zbqz47B0 for ; Tue, 3 Sep 2024 22:13:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725401601; a=rsa-sha256; cv=none; b=k6swaxh5obhXN8gosH+JHsngHfayPC36LQmoZhINagVmqE8nPKdpz2pAYqC5CxkBtzDMsr maM0vn6aA8QKKH8+pw1KK/DBBMkU3jJfGaANDUxKk3mIvirK4cgibtnKQPU7oDJY0gF76n ZyfFxohMXkle+rMHtFaHw5r7iEXlZNrRFoUhmzC94Pdlt7Kc4EXdt228xUNxLsZtVgBuyp Ae+muMfmGmM7XGo2WbaDGDXfWTzkqb9BzAW07SaTcSZ0UNKzNNwwW6ky8glan7AzzNmcA+ Z4w4kAhgYw1zQwdUYvW/RdRS5gLhB/7AHC3+nEdQ4nYJZTc+OGnxWqaNF9VdSw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725401601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NtvYRvmcXA6U2ptPXZeimscfLU556ynvM6V5Ualfdc0=; b=vLkR9VIsQgNUAZXJh0ALtqsTxQsHtlbk2ijUemMgzP2Ia59+wLK4TXfHwsHVaHh2o3CY1f yc6GlV9fBVHo4Facmw76OILHyDRXikNTszW9IYLBSmgkmEOjqHRsbOJNC0eJJnbyuetp3y /QGu+gKfZFm+Bb26Pg9vR/cvr3jj4B2UKjSG+tgReyTtzs82rTmg4ShQ3iEBeD8iKUBHSN gSXIg5523vLT9X11kG5Be2pYilOQX4VwdtYOKg+UKvXvw2i3kX5TiKzs5+0rm8N7g7Jc7M pQBMICEkh1P5s/MQEBDSuXm1iu6zgUieGeyymXRuiJvvhepLzIhsTO3fwaBueA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wz0J06blDzyg9 for ; Tue, 3 Sep 2024 22:13:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 483MDK5H078325 for ; Tue, 3 Sep 2024 22:13:20 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 483MDKiO078315 for go@FreeBSD.org; Tue, 3 Sep 2024 22:13:20 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: go@FreeBSD.org Subject: [Bug 280840] net-im/purple-gowhatsapp: maintainer upgrade from 1.15.0 to 1.16.0 Date: Tue, 03 Sep 2024 22:13:19 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: easy, patch-ready X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: vvd@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: vvd@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Go language ports maintenance List-Archive: https://lists.freebsd.org/archives/freebsd-go List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-go@freebsd.org Sender: owner-freebsd-go@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280840 --- Comment #10 from Vladimir Druzenko --- (In reply to Mikhail T. from comment #9) > You renamed $o into ${_db} -- a multi-letter variable must be > surrounded by braces in make -- which worsens the =C3=A6stethics consider= ably Disagree. "XXX${o}XXX" much better read than "XXX$oXXX". And "=C3=A6stethic= s" is better too. > Also, even though currently the only two options are, indeed, > database-related, some day they may be of other kind -- which > is why I'd prefer the more generic "o", for "option". When that happens, I'll rename it to "_opt". > The name of the multi-option is presented literally to the user -- > and my original "DB-backends" is grammatically correct, whereas > the new "DB_BACKENDS" is a perversion :( Name of option "DB-backends" look strange. Anyway I added "DB_BACKENDS_DESC=3D Database backends" with good description. > I know, you're trying to please portclippy et al, but I think, > you're following it a little too blindly. No. I trying make port better. portclippy is just tool with recommendations. The port needs to be written in such a way that other developers don't waste time trying to figure out the intricacies that another developer has create= d. Large open source and commercial projects are not the place to show off your programming acrobatics. This should be done in personal, academic projects = or programming contests. So if you have no other arguments, I insist on the proposed changes, aimed = at improving the understanding of the port by other developers. --=20 You are receiving this mail because: You are on the CC list for the bug.=