[Bug 280840] net-im/purple-gowhatsapp: maintainer upgrade from 1.15.0 to 1.16.0

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280840

Mikhail T. <freebsd-2024@virtual-estates.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252922|maintainer-approval?        |maintainer-approval-
              Flags|                            |

--- Comment #9 from Mikhail T. <freebsd-2024@virtual-estates.net> ---
Comment on attachment 252922
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=252922
v1: sort options, align lines, pet portclippy and portlint

> but I renamed $o with $_db

You renamed $o into ${_db} -- a multi-letter variable must be surrounded by
braces in make -- which worsens the æstethics considerably :( Also, even though
currently the only two options are, indeed, database-related, some day they may
be of other kind -- which is why I'd prefer the more generic "o", for "option".

The name of the multi-option is presented literally to the user -- and my
original "DB-backends" is grammatically correct, whereas the new "DB_BACKENDS"
is a perversion :(

I know, you're trying to please portclippy et al, but I think, you're following
it a little too blindly.

The sorting of the options makes sense, but other changes are unappealing...

Thank you!

-- 
You are receiving this mail because:
You are on the CC list for the bug.